Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that update internal requests share the same original headers and request context #7766

Merged
merged 2 commits into from Sep 18, 2014

Conversation

Projects
None yet
3 participants
@javanna
Copy link
Member

commented Sep 17, 2014

Update request internally executes index and delete operations. We need to make sure that those internal operations hold the same headers and context as the original update request. Achieved via copy constructors that accept the current request and the original request.

@javanna javanna self-assigned this Sep 17, 2014

@javanna javanna changed the title Internal: make sure that update internal requests share the same origina headers and request context Internal: make sure that update internal requests share the same original headers and request context Sep 17, 2014

@kimchy

This comment has been minimized.

Copy link
Member

commented Sep 18, 2014

LGTM

javanna added some commits Sep 16, 2014

Internal: make sure that all delete mapping internal requests share t…
…he same original headers and context

Delete mapping executes flush, delete by query and refresh operations internally. Those internal requests are now initialized by passing in the original delete mapping request so that its headers and request context are kept around.

Closes #7736
Internal: make sure that update internal requests share the same orig…
…inal headers and request context

Update request internally executes index and delete operations. We need to make sure that those internal operations hold the same headers and context as the original update request. Achieved via copy constructors that accept the current request and the original request.

Closes #7766

@javanna javanna force-pushed the javanna:enhancement/update_headers branch to 6717de9 Sep 18, 2014

javanna added a commit to javanna/elasticsearch that referenced this pull request Sep 18, 2014

Internal: make sure that update internal requests share the same orig…
…inal headers and request context

Update request internally executes index and delete operations. We need to make sure that those internal operations hold the same headers and context as the original update request. Achieved via copy constructors that accept the current request and the original request.

Closes elastic#7766

javanna added a commit to javanna/elasticsearch that referenced this pull request Sep 18, 2014

Internal: make sure that update internal requests share the same orig…
…inal headers and request context

Update request internally executes index and delete operations. We need to make sure that those internal operations hold the same headers and context as the original update request. Achieved via copy constructors that accept the current request and the original request.

Closes elastic#7766

@javanna javanna merged commit 6717de9 into elastic:master Sep 18, 2014

@javanna javanna removed the review label Sep 18, 2014

@clintongormley clintongormley changed the title Internal: make sure that update internal requests share the same original headers and request context Make sure that update internal requests share the same original headers and request context Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Internal: make sure that update internal requests share the same orig…
…inal headers and request context

Update request internally executes index and delete operations. We need to make sure that those internal operations hold the same headers and context as the original update request. Achieved via copy constructors that accept the current request and the original request.

Closes elastic#7766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.