Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to increment store before searcher is acquired #7792

Merged
merged 1 commit into from Sep 18, 2014

Conversation

Projects
None yet
5 participants
@s1monw
Copy link
Contributor

s1monw commented Sep 18, 2014

InternalEngine#refreshNeeded must increment the ref count on the
store used before it's checking if the searcher is current since
internally a searcher ref is acquired and if that happens concurrently
to a engine close it might violate the assumption that all files
are closed when the store is closed.

This commit also converts some try / finally into try / with.

[ENGINE] try increment store before searcher is acquired
InternalEngine#refreshNeeded must increment the ref count on the
store used before it's checking if the searcher is current since
internally a searcher ref is acquired and if that happens concurrently
to a engine close it might violate the assumption that all files
are closed when the store is closed.

This commit also converts some try / finally into try / with.
@mikemccand

This comment has been minimized.

Copy link
Contributor

mikemccand commented Sep 18, 2014

LGTM

1 similar comment
@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Sep 18, 2014

LGTM

@s1monw s1monw merged commit 9f6d6d5 into elastic:master Sep 18, 2014

@s1monw s1monw deleted the s1monw:inc_store_on_refreshNeeded branch Sep 19, 2014

@clintongormley clintongormley changed the title [ENGINE] try increment store before searcher is acquired Internal: Try to increment store before searcher is acquired Sep 26, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title Internal: Try to increment store before searcher is acquired Try to increment store before searcher is acquired Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.