Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ForceSyncDirectory #7804

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@mikemccand
Copy link
Contributor

mikemccand commented Sep 19, 2014

Looks like this is historical, now unused code ...

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Sep 19, 2014

LGTM, I suggest though not removing the toString impl, its cleaner instead of the simple class name (which is long and not nice for internal classes).

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Sep 19, 2014

btw, I think this can also go to 1.4

@mikemccand

This comment has been minimized.

Copy link
Contributor Author

mikemccand commented Sep 19, 2014

OK I'll keep the toString, and put in 1.4 as well.

@mikemccand mikemccand removed the review label Sep 19, 2014

mikemccand added a commit that referenced this pull request Sep 19, 2014

Internal: remove ForceSyncDirectory
Historical code, not used anymore.

Closes #7804

mikemccand added a commit that referenced this pull request Sep 19, 2014

Internal: remove ForceSyncDirectory
Historical code, not used anymore.

Closes #7804

@clintongormley clintongormley changed the title Internal: remove ForceSyncDirectory Remove unused ForceSyncDirectory Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Internal: remove ForceSyncDirectory
Historical code, not used anymore.

Closes elastic#7804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.