Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Fix NPE in /_cat/nodes #7815

Merged
merged 1 commit into from Sep 23, 2014

Conversation

Projects
None yet
4 participants
@imotov
Copy link
Member

commented Sep 22, 2014

Query Cache and Suggest stats were introduced in v1.4.0_beta1 and 1.2.0 respectively, therefore they can be null if stats are received from older nodes in the cluster.

Fixes #6297

This problem can occur only 1.x since current master isn't backward compatible with previous versions of elasticsearch anyway. So, I am opening this PR against 1.x not master. Not sure if this is right thing to do.

@bleskes

This comment has been minimized.

Copy link
Member

commented Sep 22, 2014

LGTM

Fix NPE in /_cat/nodes
Query Cache and Suggest stats were introduced in v1.4.0_beta1 and 1.2.0 respectively, therefore they can be null while stats are received from older nodes in the cluster.

Fixes #6297

@imotov imotov force-pushed the imotov:issue-6297-npe-in-cat-nodes branch to 8b67107 Sep 23, 2014

@imotov imotov merged commit 8b67107 into elastic:1.x Sep 23, 2014

@clintongormley clintongormley added the >bug label Sep 26, 2014

@clintongormley clintongormley changed the title Fix NPE in /_cat/nodes Stats: Fix NPE in /_cat/nodes Sep 26, 2014

@jpountz jpountz removed the review label Oct 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.