Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Lucene 4.10.1 snapshot #7844

Closed
wants to merge 9 commits into from

Conversation

Projects
None yet
5 participants
@mikemccand
Copy link
Contributor

mikemccand commented Sep 23, 2014

Upgrades to a snapshot release of 4.10.1, hopefully sidestepping the 1.8.0_20 JVM bug we've been hitting in our builds recently after we upgraded to 4.10.0. This also gives us test coverage of the upcoming Lucene point release...

Closes #7905

@rmuir

This comment has been minimized.

Copy link
Contributor

rmuir commented Sep 23, 2014

Looks good. I thought the virus scanner would have to be disabled everywhere. Do you have an idea if the two problems are real bugs or just test bugs?

@rjernst

This comment has been minimized.

Copy link
Member

rjernst commented Sep 23, 2014

This looks good. I see you have a 1.4 beta label here. Does that mean you are planning on changing the 1.4 branch to use this as well? I just want to make there is no chance we accidentally release with that? Seems like before release we should remove the repository too.

@mikemccand

This comment has been minimized.

Copy link
Contributor Author

mikemccand commented Sep 24, 2014

I thought the virus scanner would have to be disabled everywhere.

In fact I had to re-disable it: tests did fail (sometimes).

I see you have a 1.4 beta label here.

Yeah, I think we must upgrade to Lucene 4.10.1 before releasing, else users may hit this nasty 1.8.0_20 JVM bug.

I just want to make there is no chance we accidentally release with that? Seems like before release we should remove the repository too.

I agree: I pushed changes to dev-tools/build_release.py that peek at pom.xml and make sure we are not pointing to the snapshots repository, and that the lucene version is not a snapshot.

@mikemccand

This comment has been minimized.

Copy link
Contributor Author

mikemccand commented Sep 24, 2014

Do you have an idea if the two problems are real bugs or just test bugs?

One of them (DistributorDirectoryTest) is a test bug: it extends BaseDirectoryTestCase, but in its getDirectory() method it's using MockDirectoryWrappers which BaseDirectoryTestCase does not "support", since it assumes/requires .deleteFile will succeed ... maybe the test should remove the MockDirectoryWrapper when it sees it... not sure.

@mikemccand mikemccand self-assigned this Sep 24, 2014

@clintongormley clintongormley changed the title Core: upgrade to Lucene 4.10.1 snapshot Internal: Upgrade to Lucene 4.10.1 snapshot Sep 26, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title Internal: Upgrade to Lucene 4.10.1 snapshot Upgrade to Lucene 4.10.1 snapshot Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.