Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify when a shard search request gets created to be only used locally #7855

Closed
wants to merge 1 commit into from
Closed

Clarify when a shard search request gets created to be only used locally #7855

wants to merge 1 commit into from

Commits on Oct 8, 2014

  1. Internal: split shard search request into a local and a transport var… 

    …iant

In some cases a shard search request gets created on a node to be only used there and never sent over the transport. This commit clarifies that and creates a new base class called `ShardSearchLocalRequest` that can and will be only used locally. `ShardSearchTransportRequest` on the other hand delegates to the local version but extends `TransportRequest` and is `Streamable`, which means that it is supposed to be sent over the transport.

This way we can make the `OriginalIndices` only required (and mandatory now) in the transport variant.

Took the chance to remove an unused InternalScrollSearchRequest constructor and an empty else branch in `TransportSearchScrollQueryAndFetchAction`.

Closes elastic#7855
    @javanna
    javanna committed Oct 8, 2014
    Copy the full SHA
    021cb84 View commit details
    Browse the repository at this point in the history