Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NumberFormatException in Simple Query String Query #7876

Conversation

Projects
None yet
4 participants
@imotov
Copy link
Member

commented Sep 25, 2014

Incorrect usage of XContentParser.hasTextCharacters() can result in NumberFormatException as well as other possible issues in template query parser and phrase suggest parsers.

Fixes #7875

@areek

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2014

LGTM!

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2014

LGTM

@s1monw s1monw removed the review label Sep 25, 2014

Fix NumberFormatException in Simple Query String Query
Incorrect usage of XContentParser.hasTextCharacters() can result in NumberFormatException as well as other possible issues in template query parser and phrase suggest parsers.

Fixes #7875

@imotov imotov force-pushed the imotov:issue-7875-number-format-exception-in-simple-query-string branch to 9c9cd01 Sep 26, 2014

@imotov imotov merged commit 9c9cd01 into elastic:master Sep 26, 2014

@clintongormley clintongormley changed the title Fix NumberFormatException in Simple Query String Query Query DSL: Fix NumberFormatException in Simple Query String Query Sep 26, 2014

@clintongormley clintongormley changed the title Query DSL: Fix NumberFormatException in Simple Query String Query Fix NumberFormatException in Simple Query String Query Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.