Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During discovery, master fault detection should fall back to cluster state thread upon error #7908

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@bleskes
Copy link
Member

bleskes commented Sep 29, 2014

With #7834, we simplified ZenDiscovery by making it use the current cluster state for all it's decision. This had the side effect a node may start it's Master FD before the master has fully processed that cluster state update that adds that node (or elects the master master). This is due to the fact that master FD is started when a node receives a cluster state from the master but the master it self may still be publishing to other node.

This commit makes sure that a master FD ping is only failed once we know that there is no current cluster state update in progress.

Discovery: master fault detection fall back to cluster state thread u…
…pon error

With #7834, we simplified ZenDiscovery by making it use the current cluster state for all it's decision. This had the side effect a node may start it's Master FD before the master  has fully processed that cluster state update that adds that node (or elects the master master). This is due to the fact that master FD is started when a node receives a cluster state from the master but the master it self may still be publishing to other node.

 This commit makes sure that a master FD ping is only failed once we know that there is no current cluster state update in progress.
@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Sep 29, 2014

LGTM

1 similar comment
@martijnvg

This comment has been minimized.

Copy link
Member

martijnvg commented Sep 29, 2014

LGTM

@bleskes bleskes closed this in 03d880d Sep 29, 2014

bleskes added a commit that referenced this pull request Sep 29, 2014

Discovery: master fault detection fall back to cluster state thread u…
…pon error

With #7834, we simplified ZenDiscovery by making it use the current cluster state for all it's decision. This had the side effect a node may start it's Master FD before the master  has fully processed that cluster state update that adds that node (or elects the master master). This is due to the fact that master FD is started when a node receives a cluster state from the master but the master it self may still be publishing to other node.

This commit makes sure that a master FD ping is only failed once we know that there is no current cluster state update in progress.

Closes #7908

bleskes added a commit that referenced this pull request Sep 29, 2014

Discovery: master fault detection fall back to cluster state thread u…
…pon error

With #7834, we simplified ZenDiscovery by making it use the current cluster state for all it's decision. This had the side effect a node may start it's Master FD before the master  has fully processed that cluster state update that adds that node (or elects the master master). This is due to the fact that master FD is started when a node receives a cluster state from the master but the master it self may still be publishing to other node.

This commit makes sure that a master FD ping is only failed once we know that there is no current cluster state update in progress.

Closes #7908

@clintongormley clintongormley changed the title Discovery: master fault detection fall back to cluster state thread upon error Resiliency: During discovery, master fault detection should fall back to cluster state thread upon error Oct 1, 2014

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title Resiliency: During discovery, master fault detection should fall back to cluster state thread upon error During discovery, master fault detection should fall back to cluster state thread upon error Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Discovery: master fault detection fall back to cluster state thread u…
…pon error

With elastic#7834, we simplified ZenDiscovery by making it use the current cluster state for all it's decision. This had the side effect a node may start it's Master FD before the master  has fully processed that cluster state update that adds that node (or elects the master master). This is due to the fact that master FD is started when a node receives a cluster state from the master but the master it self may still be publishing to other node.

This commit makes sure that a master FD ping is only failed once we know that there is no current cluster state update in progress.

Closes elastic#7908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.