Remove binary field after attachment processor execution #79172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping the binary as a field within the document might consume a lot of resources. It is highly recommended to remove that field from the document, which can be done by adding a `remove` processor in th pipeline. This commit allows an easier way of doing this by adding a new option `remove_binary`. When set to `true`, it removes automatically the field at the end of the processor execution. It defaults to `false` to keep the existing behavior and not introduce any breaking change.
dadoonet
added
>enhancement
:Data Management/Ingest Node
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Looks good to me. My only question is whether we'd want to change the default to true at some point in the future? I'd be surprised if most people wanted the binary. I think we discussed this, and @dakrone wanted to keep the default behavior the same though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the binary as a field within the document might consume a lot of resources. It is highly recommended to remove that field from the document, which can be done by adding a
removeprocessor in th pipeline.This commit allows an easier way of doing this by adding a new option
remove_binary.When set to
true, it removes automatically the field at the end of the processor execution.It defaults to
falseto keep the existing behavior and not introduce any breaking change.