Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimize behavior with 'force' and 'flush' flags. #7920

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@rjernst
Copy link
Member

rjernst commented Sep 29, 2014

This does the following:

  • Make 'force' flag only build a merge if the delegate MP returned no merges
  • Add async handling for 'flush' when 'waitForMerges' is false
  • Remove flush at the beginning of optimize. This is something the user can
    do if they wish, before calling optimize.

closes #7886
closes #7904

Fix optimize behavior with 'force' and 'flush' flags.
This does the following:
* Make 'force' flag only build a merge if the delegate MP returned no merges
* Add async handling for 'flush' when 'waitForMerges' is false
* Remove flush at the beginning of optimize.  This is something the user can
  do if they wish, before calling optimize.

closes #7886
closes #7904
@mikemccand

This comment has been minimized.

Copy link
Contributor

mikemccand commented Sep 29, 2014

LGTM

@rjernst rjernst closed this in 37b294a Sep 29, 2014

rjernst added a commit that referenced this pull request Sep 29, 2014

Fix optimize behavior with 'force' and 'flush' flags.
This does the following:
* Make 'force' flag only build a merge if the delegate MP returned no merges
* Add async handling for 'flush' when 'waitForMerges' is false
* Remove flush at the beginning of optimize.  This is something the user can
  do if they wish, before calling optimize.

closes #7886
closes #7904
closes #7920

rjernst added a commit that referenced this pull request Sep 30, 2014

Fix optimize behavior with 'force' and 'flush' flags.
This does the following:
* Make 'force' flag only build a merge if the delegate MP returned no merges
* Add async handling for 'flush' when 'waitForMerges' is false
* Remove flush at the beginning of optimize.  This is something the user can
  do if they wish, before calling optimize.

closes #7886
closes #7904
closes #7920

rjernst added a commit that referenced this pull request Sep 30, 2014

@clintongormley clintongormley changed the title Fix optimize behavior with 'force' and 'flush' flags. Internal: Fix optimize behavior with 'force' and 'flush' flags. Oct 1, 2014

@rjernst rjernst deleted the rjernst:pr/optimize branch Jan 21, 2015

@clintongormley clintongormley changed the title Internal: Fix optimize behavior with 'force' and 'flush' flags. Fix optimize behavior with 'force' and 'flush' flags. Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Fix optimize behavior with 'force' and 'flush' flags.
This does the following:
* Make 'force' flag only build a merge if the delegate MP returned no merges
* Add async handling for 'flush' when 'waitForMerges' is false
* Remove flush at the beginning of optimize.  This is something the user can
  do if they wish, before calling optimize.

closes elastic#7886
closes elastic#7904
closes elastic#7920

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.