Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config path extraction from plugin handle #7935

Merged

Conversation

Projects
None yet
4 participants
@spinscale
Copy link
Member

spinscale commented Sep 30, 2014

The PluginManager had a subtle bug in case the config directory was not in the
es home directory - which is always true in case of packaging.

This fixes the plugin manager, so that when specifying a path.home and a
path.conf variable on the commandline, the plugin manager acts
appropriately.

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 30, 2014

LGTM

@spinscale spinscale force-pushed the spinscale:fix/pluginmanager-configure-config-path branch Sep 30, 2014

PluginManager: Fix config path extraction from plugin handle
The PluginManager had a subtle bug in case the config directory was not in the
es home directory - which is always true in case of packaging.

This fixes the plugin manager, so that when specifying a path.home and a
path.conf variable on the commandline, the plugin manager acts
appropriately.

@spinscale spinscale force-pushed the spinscale:fix/pluginmanager-configure-config-path branch to 9903c24 Sep 30, 2014

@spinscale spinscale merged commit 9903c24 into elastic:master Sep 30, 2014

@dadoonet

This comment has been minimized.

Copy link
Member

dadoonet commented Nov 1, 2014

@spinscale I think we should try to fix this in 1.3 as well. WDYT?

@spinscale

This comment has been minimized.

Copy link
Member Author

spinscale commented Nov 1, 2014

@dadoonet valid point, I agree
@clintongormley objections?

@clintongormley

This comment has been minimized.

Copy link
Member

clintongormley commented Nov 1, 2014

@spinscale none - add to 1.3.5 as well

@spinscale

This comment has been minimized.

Copy link
Member Author

spinscale commented Nov 2, 2014

done

@clintongormley clintongormley changed the title PluginManager: Fix config path extraction from plugin handle Fix config path extraction from plugin handle Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.