Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only accept unicast pings once started #7950

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@bleskes
Copy link
Member

commented Oct 1, 2014

Due to component start order we may process an incoming ping while the ZenDiscovery module is not yet started. This leads to exception (from which we recover correctly, but the logs are note nice). UnicastZenPing should only start processing pings if it is started. We previously processed if not closed or stopped.

Discovery: only accept unicast pings when started
Due to component start order we may process an incoming ping while the ZenDiscovery module is not yet started. This leads to exception (from which we recover correctly, but the logs are note nice). UnicastZenPing should only start processing pings if it is started. We previously processed if not closed or stopped.
@s1monw

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

LGTM

@bleskes bleskes closed this in ab5d1b9 Oct 2, 2014

bleskes added a commit that referenced this pull request Oct 2, 2014

Discovery: only accept unicast pings when started
Due to component start order we may process an incoming ping while the ZenDiscovery module is not yet started. This leads to exception (from which we recover correctly, but the logs are note nice). UnicastZenPing should only start processing pings if it is started. We previously processed if not closed or stopped.

Closes #7950

bleskes added a commit that referenced this pull request Oct 2, 2014

Discovery: only accept unicast pings when started
Due to component start order we may process an incoming ping while the ZenDiscovery module is not yet started. This leads to exception (from which we recover correctly, but the logs are note nice). UnicastZenPing should only start processing pings if it is started. We previously processed if not closed or stopped.

Closes #7950

@bleskes bleskes deleted the bleskes:unicast_ping_started branch Oct 2, 2014

bleskes added a commit that referenced this pull request Oct 2, 2014

Discovery: only accept unicast pings when started
Due to component start order we may process an incoming ping while the ZenDiscovery module is not yet started. This leads to exception (from which we recover correctly, but the logs are note nice). UnicastZenPing should only start processing pings if it is started. We previously processed if not closed or stopped.

Closes #7950

@s1monw s1monw removed the review label Oct 2, 2014

@clintongormley clintongormley changed the title Discovery: only accept unicast pings when started Discovery: Only accept unicast pings when started Nov 3, 2014

@clintongormley clintongormley changed the title Discovery: Only accept unicast pings when started Only accept unicast pings once started Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Discovery: only accept unicast pings when started
Due to component start order we may process an incoming ping while the ZenDiscovery module is not yet started. This leads to exception (from which we recover correctly, but the logs are note nice). UnicastZenPing should only start processing pings if it is started. We previously processed if not closed or stopped.

Closes elastic#7950

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Discovery: only accept unicast pings when started
Due to component start order we may process an incoming ping while the ZenDiscovery module is not yet started. This leads to exception (from which we recover correctly, but the logs are note nice). UnicastZenPing should only start processing pings if it is started. We previously processed if not closed or stopped.

Closes elastic#7950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.