Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`has_parent` filter must take parent filter into account when executing the inner query/filter #8020

Conversation

Projects
None yet
3 participants
@martijnvg
Copy link
Member

commented Oct 8, 2014

A bug introduced via: #7362

The has_parent query does take the parent filter into account when executing the inner query.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2014

Good catch! LGTM

@jpountz jpountz removed the review label Oct 8, 2014

Parent/child: has_parent filter must take parent filter into account …
…when executing the inner query/filter.

Closes #8020
Closes #7943

@martijnvg martijnvg force-pushed the martijnvg:bugs/has_parent_filter_does_not_take_parent_filter_into_account branch to 6b26c20 Oct 8, 2014

@martijnvg martijnvg merged commit 6b26c20 into elastic:master Oct 8, 2014

martijnvg added a commit that referenced this pull request Oct 8, 2014

Parent/child: has_parent filter must take parent filter into account …
…when executing the inner query/filter.

Closes #8020
Closes #7943

martijnvg added a commit that referenced this pull request Oct 8, 2014

Parent/child: has_parent filter must take parent filter into account …
…when executing the inner query/filter.

Closes #8020
Closes #7943

brwe added a commit that referenced this pull request Oct 8, 2014

brwe added a commit that referenced this pull request Oct 8, 2014

brwe added a commit that referenced this pull request Oct 8, 2014

martijnvg added a commit that referenced this pull request Oct 8, 2014

Parent/child: has_parent filter must take parent filter into account …
…when executing the inner query/filter.

Closes #8020
Closes #7943

@clintongormley clintongormley changed the title Parent/child: has_parent filter must take parent filter into account when executing the inner query/filter Parent/child: `has_parent` filter must take parent filter into account when executing the inner query/filter Nov 3, 2014

@martijnvg martijnvg deleted the martijnvg:bugs/has_parent_filter_does_not_take_parent_filter_into_account branch May 18, 2015

@clintongormley clintongormley changed the title Parent/child: `has_parent` filter must take parent filter into account when executing the inner query/filter `has_parent` filter must take parent filter into account when executing the inner query/filter Jun 8, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.