Improve Slow Inbound Handling to Include Response Type #80425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The slow logging for responses is often relatively uselss when debugging because it does not contain the type of the response. Tracking down the type from the message size and response id is not possible in most cases. This commit adds the handler to the log message which gives us that type information.
original-brownbear
added
>enhancement
:Distributed/Network
|
Pinging @elastic/es-distributed (Team:Distributed) |
fcofdez
approved these changes
Nov 5, 2021
|
Thanks Francisco!
I think so, we actually fixed the |
original-brownbear
deleted the
log-response-handler-in-slow-inbound-warn
branch
pxsalehi
pushed a commit
to pxsalehi/elasticsearch
that referenced
this pull request
Dec 12, 2022
The slow logging for responses is often relatively uselss when debugging because it does not contain the type of the response. Tracking down the type from the message size and response id is not possible in most cases. This commit adds the handler to the log message which gives us that type information.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2022
The slow logging for responses is often relatively uselss when debugging because it does not contain the type of the response. Tracking down the type from the message size and response id is not possible in most cases. This commit adds the handler to the log message which gives us that type information. Co-authored-by: Armin Braun <me@obrown.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slow logging for responses is often relatively useless when debugging
because it does not contain the type of the response. Tracking down the type
from the message size and response id is not possible in most cases.
This commit adds the handler to the log message which gives us that type information.