Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoopCircuitBreaker used in NoneCircuitBreakerService #8063

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@dakrone
Copy link
Member

dakrone commented Oct 13, 2014

This adds the NoopCircuitBreaker, which is used in the
NoneCircuitBreakerService when the overhead of a circuit breaker is
undesired.

In order to use it, the setting indices.breaker.breaker_impl can be
set to org.elasticsearch.indices.breaker.NoneCircuitBreakerService.

This also adds a benchmark for CircuitBreakerService implementations, so
that the overhead of the circuit breaker can be measured.

Add NoopCircuitBreaker used in NoneCircuitBreakerService
This adds the NoopCircuitBreaker, which is used in the
NoneCircuitBreakerService when the overhead of a circuit breaker is
undesired.

In order to use it, the setting `indices.breaker.breaker_impl` can be
set to `org.elasticsearch.indices.breaker.NoneCircuitBreakerService`.

This also adds a benchmark for CircuitBreakerService implementations, so
that the overhead of the circuit breaker can be measured.
@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Oct 13, 2014

LGTM

@s1monw s1monw removed the review label Oct 13, 2014

@kimchy

This comment has been minimized.

Copy link
Member

kimchy commented Oct 13, 2014

I wonder if the benchmark is the correct way to do so? double checking it won't end up running it as part of our test infra?

@dakrone

This comment has been minimized.

Copy link
Member Author

dakrone commented Oct 13, 2014

@kimchy I will check to see if it runs during a regular test run, if it does, I'll change it to have a main method and not run.

WIP
@dakrone

This comment has been minimized.

Copy link
Member Author

dakrone commented Oct 20, 2014

Closing, this was added in #8135

@dakrone dakrone closed this Oct 20, 2014

@clintongormley clintongormley changed the title Add NoopCircuitBreaker used in NoneCircuitBreakerService Circuit Breakers: Add NoopCircuitBreaker used in NoneCircuitBreakerService Nov 3, 2014

@dakrone dakrone deleted the dakrone:measure-breaker-overhead branch Nov 11, 2014

@clintongormley clintongormley changed the title Circuit Breakers: Add NoopCircuitBreaker used in NoneCircuitBreakerService Add NoopCircuitBreaker used in NoneCircuitBreakerService Jun 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.