Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Make version parsing more lenient #8076

Merged
merged 1 commit into from Oct 14, 2014

Conversation

Projects
None yet
2 participants
@s1monw
Copy link
Contributor

s1monw commented Oct 14, 2014

Today we fall back to a beta/alpha version parsing if the first attemp
failed. Yet, if the second attemp failed we throw the exception rather
than returning the default value provided.

Note: this PR is only against 1.3 newer branches don't have this problem

@bleskes

This comment has been minimized.

Copy link
Member

bleskes commented Oct 14, 2014

LGTM

[CORE] Make version parsing more lenient
Today we fall back to a beta/alpha version parsing if the first attemp
failed. Yet, if the second attemp failed we throw the exception rather
than returning the default value provided.

@s1monw s1monw force-pushed the s1monw:version_parse_1_3 branch to e2c7123 Oct 14, 2014

@s1monw s1monw merged commit e2c7123 into elastic:1.3 Oct 14, 2014

@s1monw s1monw removed the review label Oct 14, 2014

@s1monw s1monw deleted the s1monw:version_parse_1_3 branch Oct 14, 2014

@clintongormley clintongormley changed the title [CORE] Make version parsing more lenient Internal: Make version parsing more lenient Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.