Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic changes to `max_merge_count` are now picked up by index throttling #8136

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@mikemccand
Copy link
Contributor

commented Oct 17, 2014

Today, index throttling won't notice any dynamic/live changes to max_merge_count.

So, I just fixed the throttle code to ask the MergeSchedulerProvider for its maxMergeCount every time a merge starts/finishes.

This means after a dynamic change, it will be the next merge that starts/finishes until the throttling notices the change. We could also install an UpdateSettingsListener to force throttling to notice the change immediately, but that's more complex and I think this simple solution is sufficient.

Closes #8132

@mikemccand mikemccand added the review label Oct 17, 2014

@mikemccand mikemccand self-assigned this Oct 17, 2014

@rjernst

This comment has been minimized.

Copy link
Member

commented Oct 17, 2014

LGTM.

@kimchy

This comment has been minimized.

Copy link
Member

commented Oct 17, 2014

LGTM

mikemccand added a commit that referenced this pull request Oct 18, 2014

Core: fix index throttling to notice a change to max_merge_count on t…
…he next merge start/finish

Previously such changes were never noticed, and index throttling kept
kicking in at the original setting from startup.

Closes #8136

Closes #8132

mikemccand added a commit that referenced this pull request Oct 18, 2014

Core: fix index throttling to notice a change to max_merge_count on t…
…he next merge start/finish

Previously such changes were never noticed, and index throttling kept
kicking in at the original setting from startup.

Closes #8136

Closes #8132

mikemccand added a commit that referenced this pull request Oct 18, 2014

Core: fix index throttling to notice a change to max_merge_count on t…
…he next merge start/finish

Previously such changes were never noticed, and index throttling kept
kicking in at the original setting from startup.

Closes #8136

Closes #8132

@jpountz jpountz removed the review label Oct 21, 2014

@clintongormley clintongormley changed the title Core: dynamic changes to max_merge_count are now picked up by index throttling Internal: Dynamic changes to `max_merge_count` are now picked up by index throttling Nov 3, 2014

@clintongormley clintongormley changed the title Internal: Dynamic changes to `max_merge_count` are now picked up by index throttling Dynamic changes to `max_merge_count` are now picked up by index throttling Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Core: fix index throttling to notice a change to max_merge_count on t…
…he next merge start/finish

Previously such changes were never noticed, and index throttling kept
kicking in at the original setting from startup.

Closes elastic#8136

Closes elastic#8132

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Core: fix index throttling to notice a change to max_merge_count on t…
…he next merge start/finish

Previously such changes were never noticed, and index throttling kept
kicking in at the original setting from startup.

Closes elastic#8136

Closes elastic#8132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.