Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if there is a search context, otherwise throw a query parse exception. #8177

Conversation

Projects
None yet
4 participants
@martijnvg
Copy link
Member

martijnvg commented Oct 21, 2014

Also added a bwc test that runs a delete by query with a has_child query and verifies that only that operation is ignored when recovering from disk during a upgrade.

PR for #8031

Parent/child: Check if there is a search context, otherwise throw a q…
…uery parse exception.

Also added a bwc test that runs a delete by query with a has_child query and verifies that only that operation is ignored when recovering from disk during a upgrade.
@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Oct 21, 2014

LGTM

martijnvg added a commit that referenced this pull request Oct 22, 2014

Parent/child: Check if there is a search context, otherwise throw a q…
…uery parse exception.

Also added a bwc test that runs a delete by query with a has_child query and verifies that only that operation is ignored when recovering from disk during a upgrade.

Closes #8031
Closes #8177

@martijnvg martijnvg closed this in 319878e Oct 22, 2014

martijnvg added a commit that referenced this pull request Oct 22, 2014

Parent/child: Check if there is a search context, otherwise throw a q…
…uery parse exception.

Also added a bwc test that runs a delete by query with a has_child query and verifies that only that operation is ignored when recovering from disk during a upgrade.

Closes #8031
Closes #8177

martijnvg added a commit that referenced this pull request Oct 22, 2014

Parent/child: Check if there is a search context, otherwise throw a q…
…uery parse exception.

Also added a bwc test that runs a delete by query with a has_child query and verifies that only that operation is ignored when recovering from disk during a upgrade.

Closes #8031
Closes #8177

@martijnvg martijnvg deleted the martijnvg:bugs/delete_by_query_with_pc_query__translog_recover_from_disk branch May 18, 2015

@clintongormley clintongormley changed the title Parent/child: Check if there is a search context, otherwise throw a query parse exception. Check if there is a search context, otherwise throw a query parse exception. Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Parent/child: Check if there is a search context, otherwise throw a q…
…uery parse exception.

Also added a bwc test that runs a delete by query with a has_child query and verifies that only that operation is ignored when recovering from disk during a upgrade.

Closes elastic#8031
Closes elastic#8177

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Parent/child: Check if there is a search context, otherwise throw a q…
…uery parse exception.

Also added a bwc test that runs a delete by query with a has_child query and verifies that only that operation is ignored when recovering from disk during a upgrade.

Closes elastic#8031
Closes elastic#8177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.