Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing `fielddata_fields` as a non array causes OOM #8203

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@s1monw
Copy link
Contributor

s1monw commented Oct 22, 2014

If fielddata_fields are passed as a simple value instead of an array
we end up in an infinite loop createing parsed elements with null
values.
This commit validates the incoming token

@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Oct 22, 2014

thanks to @astefan for finding this

@jpountz

This comment has been minimized.

Copy link
Contributor

jpountz commented Oct 22, 2014

LGTM

@jpountz jpountz removed the review label Oct 22, 2014

[SEARCH] Passing fieddata_fields as a non array causes OOM
If `fielddata_fields` are passed as a simple value instead of an array
we end up in an infinite loop createing parsed elements with null
values.
This commit validates the incoming token

Closes #8203

@s1monw s1monw force-pushed the s1monw:fielddata_field_oom branch to 29453a2 Oct 23, 2014

@s1monw s1monw closed this in ed79829 Oct 23, 2014

s1monw added a commit that referenced this pull request Oct 23, 2014

[SEARCH] Passing fieddata_fields as a non array causes OOM
If `fielddata_fields` are passed as a simple value instead of an array
we end up in an infinite loop createing parsed elements with null
values.
This commit validates the incoming token

Closes #8203

s1monw added a commit that referenced this pull request Oct 23, 2014

[SEARCH] Passing fieddata_fields as a non array causes OOM
If `fielddata_fields` are passed as a simple value instead of an array
we end up in an infinite loop createing parsed elements with null
values.
This commit validates the incoming token

Closes #8203

s1monw added a commit that referenced this pull request Oct 23, 2014

[SEARCH] Passing fieddata_fields as a non array causes OOM
If `fielddata_fields` are passed as a simple value instead of an array
we end up in an infinite loop createing parsed elements with null
values.
This commit validates the incoming token

Closes #8203

@clintongormley clintongormley changed the title [SEARCH] Passing fieddata_fields as a non array causes OOM Search: Passing `fieddata_fields` as a non array causes OOM Nov 3, 2014

@clintongormley clintongormley changed the title Search: Passing `fieddata_fields` as a non array causes OOM Passing `fielddata_fields` as a non array causes OOM Jun 8, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

[SEARCH] Passing fieddata_fields as a non array causes OOM
If `fielddata_fields` are passed as a simple value instead of an array
we end up in an infinite loop createing parsed elements with null
values.
This commit validates the incoming token

Closes elastic#8203

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

[SEARCH] Passing fieddata_fields as a non array causes OOM
If `fielddata_fields` are passed as a simple value instead of an array
we end up in an infinite loop createing parsed elements with null
values.
This commit validates the incoming token

Closes elastic#8203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.