Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ClusterInfoService by default #8206

Merged
merged 1 commit into from Oct 23, 2014

Conversation

Projects
None yet
4 participants
@dakrone
Copy link
Member

commented Oct 23, 2014

Since we enabled the disk threshold decider by default, we need to
enable the cluster info service so that disk usages and shard sizes can
be gathered also.

Adds a test that checks that we are gathering information by default.

I also talked to @bleskes about how to test both the
InternalClusterInfoService and DiskThresholdDecider at an integration
level, and he suggested mocking the responses at the transport layer. I
will work on that for a subsequent pull request after this one.

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2014

LGTM good catch

Enable ClusterInfoService by default
Since we enabled the disk threshold decider by default, we need to
enable the cluster info service so that disk usages and shard sizes can
be gathered also.

Adds a test that checks that we are gathering information by default.

@dakrone dakrone force-pushed the dakrone:fix-cluster-info-service branch to 19514a2 Oct 23, 2014

@dakrone dakrone merged commit 19514a2 into elastic:master Oct 23, 2014

@dakrone dakrone removed the review label Oct 23, 2014

@s1monw s1monw removed the review label Oct 23, 2014

@clintongormley clintongormley changed the title Enable ClusterInfoService by default Allocation: Enable ClusterInfoService by default Nov 3, 2014

@dakrone dakrone deleted the dakrone:fix-cluster-info-service branch Nov 11, 2014

@clintongormley clintongormley changed the title Allocation: Enable ClusterInfoService by default Enable ClusterInfoService by default Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.