Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter. #8232

Merged

Conversation

Projects
None yet
4 participants
@martijnvg
Copy link
Member

commented Oct 26, 2014

If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed.

In our case we cached the NonNestedDocsFilter itself so flipping bits each time NonNestedDocsFilter was used didn't happen. However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode()

PR for #8227

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2014

LGTM I guess this counts as a bugfix and should go on 1.4 and 1.3 as well?

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2014

LGTM

@jpountz jpountz removed the review label Oct 26, 2014

@martijnvg

This comment has been minimized.

Copy link
Member Author

commented Oct 27, 2014

@s1monw Ok, I'll add it to 1.3 and 1.4 too.

Core: Cleanup non nested filter to not flip the bits in the FixedBitS…
…et returned by the wrapped filter.

If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed.
In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used.
However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode()

Closes #8227
Closes #8232

@martijnvg martijnvg force-pushed the martijnvg:bugs/non_nested_filter_stop_flipping branch to 35ede09 Oct 27, 2014

martijnvg added a commit that referenced this pull request Oct 27, 2014

Core: Cleanup non nested filter to not flip the bits in the FixedBitS…
…et returned by the wrapped filter.

If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed.
In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used.
However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode()

Closes #8227
Closes #8232

martijnvg added a commit that referenced this pull request Oct 27, 2014

Core: Cleanup non nested filter to not flip the bits in the FixedBitS…
…et returned by the wrapped filter.

If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed.
In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used.
However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode()

Closes #8227
Closes #8232

@martijnvg martijnvg merged commit 35ede09 into elastic:master Oct 27, 2014

martijnvg added a commit that referenced this pull request Oct 27, 2014

Core: Cleanup non nested filter to not flip the bits in the FixedBitS…
…et returned by the wrapped filter.

If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed.
In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used.
However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode()

Closes #8227
Closes #8232

@clintongormley clintongormley changed the title Core: Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter. Internal: Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter. Nov 3, 2014

@martijnvg martijnvg deleted the martijnvg:bugs/non_nested_filter_stop_flipping branch May 18, 2015

@clintongormley clintongormley added :Cache and removed :Internal labels Jun 7, 2015

@clintongormley clintongormley changed the title Internal: Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter. Cleanup non nested filter to not flip the FixedBitSet returned by the wrapped filter. Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Core: Cleanup non nested filter to not flip the bits in the FixedBitS…
…et returned by the wrapped filter.

If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed.
In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used.
However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode()

Closes elastic#8227
Closes elastic#8232

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Core: Cleanup non nested filter to not flip the bits in the FixedBitS…
…et returned by the wrapped filter.

If the filter producing the FBS were to be cached then it would flip bits each time the NonNestedDocsFilter was executed.
In our case we cache the NonNestedDocsFilter itself so that didn't happen each time this filter was used.
However the hashcode of NonNestedDocsFilter and NestedDocsFilter was the same, since NonNestedDocsFilter directly used NestedDocsFilter#hashCode()

Closes elastic#8227
Closes elastic#8232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.