Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Bind each AllocationDecider as a singleton #8272

Merged
merged 1 commit into from Oct 29, 2014

Conversation

Projects
None yet
2 participants
@dakrone
Copy link
Member

dakrone commented Oct 29, 2014

Previously it's possible to have multiple AllocationDeciders created by guice, this ensures only a single instance is created per AllocationDecider.

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Oct 29, 2014

LGTM

@s1monw s1monw removed the review label Oct 29, 2014

@dakrone dakrone merged commit e75d28b into elastic:1.4 Oct 29, 2014

@clintongormley clintongormley changed the title Bind each AllocationDecider as a singleton Internal: Bind each AllocationDecider as a singleton Nov 3, 2014

@dakrone dakrone deleted the dakrone:singleton-deciders branch Nov 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.