Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict when updating mapping with _all disabled #8426

Closed
wants to merge 1 commit into from

Conversation

@brwe
Copy link
Contributor

commented Nov 10, 2014

_all reports a conflict since #7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes #8423

[root mappers] fix conflict when updating mapping with _all disabled
_all reports a conflict since #7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes #8423
@rjernst

This comment has been minimized.

Copy link
Member

commented Nov 10, 2014

LGTM.

@clintongormley

This comment has been minimized.

Copy link
Member

commented Nov 14, 2014

@brwe want to get this in?

brwe added a commit that referenced this pull request Nov 20, 2014
[root mappers] fix conflict when updating mapping with _all disabled
_all reports a conflict since #7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes #8423
closes #8426

@brwe brwe closed this in 4b5592c Nov 20, 2014

brwe added a commit that referenced this pull request Nov 20, 2014
[root mappers] fix conflict when updating mapping with _all disabled
_all reports a conflict since #7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes #8423
closes #8426

@clintongormley clintongormley changed the title [root mappers] fix conflict when updating mapping with _all disabled Mapping: Fix conflict when updating mapping with _all disabled Nov 25, 2014

@clintongormley clintongormley changed the title Mapping: Fix conflict when updating mapping with _all disabled Fix conflict when updating mapping with _all disabled Jun 7, 2015

@rayward

This comment has been minimized.

Copy link

commented Jul 7, 2015

It seems that it's not possible to disable the _all field after it was previously enabled:

{"error":"MergeMappingException[Merge failed with failures {[mapper [_all] enabled is true now encountering false]}]","status":400}

Is this intentional?

@clintongormley

This comment has been minimized.

Copy link
Member

commented Jul 8, 2015

Hi @rayward

Yes it is intentional. In fact from 2.0, the only time you'll be able to enable or disable the _all field is when you create the mapping.

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
[root mappers] fix conflict when updating mapping with _all disabled
_all reports a conflict since elastic#7377. However, it was not checked if _all
was actually configured in the updated mapping. Therefore whenever _all
was disabled a mapping could not be updated unless _all was again added to the
updated mapping.
Also, add enabled setting to mapping always whenever enabled was set explicitely.

closes elastic#8423
closes elastic#8426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.