Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index API: BWC layer for GetIndex should not block in a listener #8496

Merged
merged 1 commit into from Nov 17, 2014

Conversation

@s1monw
Copy link
Contributor

commented Nov 17, 2014

Today we execute BWC calls against nodes that have not GetIndex API
in a action listeners #onFailure method. These calls are blocking today
and might be executed on a bounded thread-pool which might deadlock the
call depending on how many threads are in the pool and how the pool is
setup. These calls should run async as well.

@colings86

This comment has been minimized.

Copy link
Member

commented Nov 17, 2014

LGTM

@colings86 colings86 removed the review label Nov 17, 2014

[BWC] BWC layer for GetIndex should not block in a listener
Today we execute BWC calls against nodes that have not GetIndex API
in a action listeners #onFailure method. These calls are blocking today
and might be executed on a bounded thread-pool which might deadlock the
call depending on how many threads are in the pool and how the pool is
setup. These calls should run async as well.

@s1monw s1monw force-pushed the s1monw:async_bwc_get_indices branch to 584f65a Nov 17, 2014

@s1monw s1monw merged commit 584f65a into elastic:1.x Nov 17, 2014

@s1monw s1monw deleted the s1monw:async_bwc_get_indices branch Nov 17, 2014

@clintongormley clintongormley changed the title [BWC] BWC layer for GetIndex should not block in a listener Index API: BWC layer for GetIndex should not block in a listener Nov 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.