Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot status messages on node-left #85021

Conversation

DaveCTurner
Copy link
Contributor

Today we report node shutdown if a node leaves the cluster during a
snapshot. That's not the only reason for a node to leave the cluster, it
might have been a network disconnect or health check failure or similar.
This commit generalizes the message.

Today we report `node shutdown` if a node leaves the cluster during a
snapshot. That's not the only reason for a node to leave the cluster, it
might have been a network disconnect or health check failure or similar.
This commit generalizes the message.
@DaveCTurner DaveCTurner added >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.2.0 labels Mar 16, 2022
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Mar 16, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@DaveCTurner DaveCTurner added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 16, 2022
@elasticsearchmachine elasticsearchmachine merged commit a8394e0 into elastic:master Mar 16, 2022
@DaveCTurner DaveCTurner deleted the 2022-03-16-node-left-during-snapshot-messages branch March 16, 2022 12:49
CohenIdo pushed a commit to CohenIdo/elasticsearch that referenced this pull request Mar 24, 2022
Today we report `node shutdown` if a node leaves the cluster during a
snapshot. That's not the only reason for a node to leave the cluster, it
might have been a network disconnect or health check failure or similar.
This commit generalizes the message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants