Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some more bwc code #8778

Merged
merged 1 commit into from Dec 4, 2014

Conversation

@javanna
Copy link
Member

commented Dec 4, 2014

Some more code that was left for backwards compatibility can now be removed on master since 2.0 will require a full cluster restart.

@javanna javanna force-pushed the javanna:enhancement/remove_bwc_leftovers branch Dec 4, 2014
@s1monw
s1monw reviewed Dec 4, 2014
View changes
src/test/java/org/elasticsearch/search/query/SimpleQueryTests.java Outdated
@@ -449,39 +449,6 @@ public void testCommonTermsQueryStackedTokens() throws Exception {
}

@Test
public void testOmitTermFreqsAndPositions() throws Exception {

This comment has been minimized.

Copy link
@s1monw

s1monw Dec 4, 2014

Contributor

why did you remove this? I think it's still valid?

This comment has been minimized.

Copy link
@javanna

javanna Dec 4, 2014

Author Member

Right, I was not 100% sure either... will restore

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2014

left one comment other than that LGTM

@javanna javanna force-pushed the javanna:enhancement/remove_bwc_leftovers branch Dec 4, 2014
Some more code that was left for backwards compatibility can now be removed on master since 2.0 will require a full cluster restart.

Closes #8778
@javanna javanna force-pushed the javanna:enhancement/remove_bwc_leftovers branch to 95c2d84 Dec 4, 2014
@javanna javanna merged commit 95c2d84 into elastic:master Dec 4, 2014
@javanna javanna removed the review label Dec 4, 2014
@dadoonet

This comment has been minimized.

Copy link
Member Author

replied Dec 17, 2014

good catch @dadoonet I see where this was used now :) We can restore it if needed and document who uses it and how. Maybe also take the chance to see if we can do things differently for 2.0.

@clintongormley clintongormley changed the title Internal: remove some more bwc code Remove some more bwc code Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.