Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove engine related command classes #8900

Merged
merged 1 commit into from Dec 11, 2014

Conversation

Projects
None yet
3 participants
@s1monw
Copy link
Contributor

s1monw commented Dec 11, 2014

Todaqy we pass structs to the engine to call optimize / refresh and flush.
This commit cleans up this logic to reduce complexity in the engine.

@mikemccand

This comment has been minimized.

Copy link
Contributor

mikemccand commented Dec 11, 2014

LGTM

I just saw one typo..

It's nice to remove these un-needed indirections.

[ENGINE] Remove engine related command classes
Todaqy we pass structs to the engine to call optimize / refresh and flush.
This commit cleans up this logic to reduce complexity in the engine.

@s1monw s1monw force-pushed the s1monw:cleanup_engine branch to ba881a9 Dec 11, 2014

@s1monw s1monw merged commit ba881a9 into elastic:master Dec 11, 2014

@clintongormley clintongormley added :Engine and removed review labels Mar 19, 2015

@clintongormley clintongormley changed the title [ENGINE] Remove engine related command classes Remove engine related command classes Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.