New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptService can deadlock entire nodes if script index is recovering #8901

Merged
merged 1 commit into from Dec 11, 2014

Conversation

Projects
None yet
3 participants
@s1monw
Contributor

s1monw commented Dec 11, 2014

we currently have operationThreaded set to false when indexing a script. This setting
means that if we are executing the operation locally that we don't spawn a new thread for
it although incoming thread in this case is the network thread. Now since we are indexing here
the engine is currently recovering which sometimes locks the engine for finalization blocks on
a network call waiting for the recovery target to come back the internal lock in engine will never be
released since we are waiting with our network thread for it to be released.

here is a smoking gun:

http://build-us-00.elasticsearch.org/job/es_core_1x_suse/164/

the interested reader follows the thread dump ;)

@bleskes

This comment has been minimized.

Show comment
Hide comment
@bleskes

bleskes Dec 11, 2014

Member

LGTM

Member

bleskes commented Dec 11, 2014

LGTM

[SCRIPT] ScriptService can deadlock entire nodes if script index is r…
…ecovering

we currently have operationThreaded set to false when indexing a script. This setting
means that if we are executing the operation locally that we don't spawn a new thread for
it althought incoming thread in this case is the network thread. Now sicne we are indexing here
the engine is currently recovering which sometimes locks the engine for finalization blocks on
a network call waiting for the recovery target to come back the internal lock in engine will never be
released since we are waiting with our network thread for it to be released.

@s1monw s1monw merged commit 123fb2f into elastic:master Dec 11, 2014

@clintongormley clintongormley changed the title from [SCRIPT] ScriptService can deadlock entire nodes if script index is recovering to Scripting: ScriptService can deadlock entire nodes if script index is recovering Dec 16, 2014

@clintongormley clintongormley changed the title from Scripting: ScriptService can deadlock entire nodes if script index is recovering to ScriptService can deadlock entire nodes if script index is recovering Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment