Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't acquire Engine's readLock in segmentsStats #8910

Closed
wants to merge 1 commit into from

Conversation

@mikemccand
Copy link
Contributor

commented Dec 11, 2014

I think we don't really need the readLock in InternalEngine.segmentsStats?

Related to #8905

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2014

LGTM

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2014

can we do this on 1.3.7 too?

@mikemccand

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2014

kk i'll port to 1.3.7 too

@mikemccand mikemccand added the v1.3.7 label Dec 12, 2014

mikemccand added a commit that referenced this pull request Dec 12, 2014
Core: don't block shard stats when phase 3 of recovery is running
Today, shard stats are blocked while phase 3 of recovery (replay xlog)
is running; this change removes the engine readLock from shard stats
so it's not blocked.

Closes #8910
mikemccand added a commit that referenced this pull request Dec 12, 2014
Core: don't block shard stats when phase 3 of recovery is running
Today, shard stats are blocked while phase 3 of recovery (replay xlog)
is running; this change removes the engine readLock from shard stats
so it's not blocked.

Closes #8910
mikemccand added a commit that referenced this pull request Dec 12, 2014
Core: don't block shard stats when phase 3 of recovery is running
Today, shard stats are blocked while phase 3 of recovery (replay xlog)
is running; this change removes the engine readLock from shard stats
so it's not blocked.

Closes #8910

@clintongormley clintongormley changed the title Core: don't acquire Engine's readLock in segmentsStats Core: Don't acquire Engine's readLock in segmentsStats Dec 16, 2014

@clintongormley clintongormley added :Engine and removed review labels Mar 19, 2015

@clintongormley clintongormley changed the title Core: Don't acquire Engine's readLock in segmentsStats Don't acquire Engine's readLock in segmentsStats Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Core: don't block shard stats when phase 3 of recovery is running
Today, shard stats are blocked while phase 3 of recovery (replay xlog)
is running; this change removes the engine readLock from shard stats
so it's not blocked.

Closes elastic#8910
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Core: don't block shard stats when phase 3 of recovery is running
Today, shard stats are blocked while phase 3 of recovery (replay xlog)
is running; this change removes the engine readLock from shard stats
so it's not blocked.

Closes elastic#8910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.