Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlainTransportFuture should not set currentThread().interrupt() #9001

Closed
wants to merge 1 commit into from

Conversation

@bleskes
Copy link
Member

commented Dec 18, 2014

We use PlainTransportFuture as a future for our transport calls. If someone blocks on it and it is interrupted, we throw an ElasticsearchIllegalStateException. We should not set Thread.currentThread().interrupt(); in this case because we already communicate the interrupt through an exception.

…pt()

We use PlainTransportFuture as a future for our transport calls. If someone blocks on it and it is interrupted, we throw an ElasticsearchIllegalStateException. We should not set  Thread.currentThread().interrupt(); in this case because we already communicate the interrupt through an exception.
@mikemccand

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2014

+1

@bleskes bleskes added the v1.5.0 label Dec 18, 2014
@bleskes bleskes closed this in b9db5b1 Dec 18, 2014
bleskes added a commit that referenced this pull request Dec 18, 2014
…pt()

We use PlainTransportFuture as a future for our transport calls. If someone blocks on it and it is interrupted, we throw an ElasticsearchIllegalStateException. We should not set  Thread.currentThread().interrupt(); in this case because we already communicate the interrupt through an exception.

Closes #9001
@bleskes bleskes deleted the bleskes:interrupt_action branch Dec 18, 2014
bleskes added a commit to bleskes/elasticsearch that referenced this pull request Jan 5, 2015
If someone blocks on it and it is interrupted, we throw an ElasticsearchIllegalStateException. We should not set Thread.currentThread().interrupt(); in this case because we already communicate the interrupt through an exception.

Similar to elastic#9001
bleskes added a commit that referenced this pull request Jan 6, 2015
If someone blocks on it and it is interrupted, we throw an ElasticsearchIllegalStateException. We should not set Thread.currentThread().interrupt(); in this case because we already communicate the interrupt through an exception.

Similar to #9001

Closes #9141
bleskes added a commit that referenced this pull request Jan 6, 2015
If someone blocks on it and it is interrupted, we throw an ElasticsearchIllegalStateException. We should not set Thread.currentThread().interrupt(); in this case because we already communicate the interrupt through an exception.

Similar to #9001

Closes #9141
@clintongormley clintongormley added :Internal and removed review labels Mar 19, 2015
@clintongormley clintongormley changed the title Internal: PlainTransportFuture should not set currentThread().interrupt() PlainTransportFuture should not set currentThread().interrupt() Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.