Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency issues of the _parent field data. #9030

Closed
wants to merge 2 commits into from

Conversation

@jpountz
Copy link
Contributor

commented Dec 22, 2014

_parent field data mistakenly shared some stateful data-structures
(SortedDocValues) across threads.

Close #8396

Parent/child: Fix concurrency issues of the _parent field data.
`_parent` field data mistakenly shared some stateful data-structures across
threads.

Close #8396

@jpountz jpountz added the review label Dec 22, 2014

@@ -184,6 +199,62 @@ public void testSorting() throws Exception {
assertThat(((FieldDoc) topDocs.scoreDocs[7]).fields[0], nullValue());
}

public void testThreads() throws Throwable {

This comment has been minimized.

Copy link
@martijnvg

martijnvg Dec 23, 2014

Member

Maybe just throw Exception? (the error variable generic type should then get changed as well)

@martijnvg

This comment has been minimized.

Copy link
Member

commented Dec 23, 2014

Left one minor comment, otherwise LGTM

@martijnvg martijnvg removed the review label Dec 23, 2014

@martijnvg

This comment has been minimized.

Copy link
Member

commented Dec 23, 2014

Also this PR or the actual bug report should get the 1.4.3, 1.5 and 2.0 labels?

@jpountz

This comment has been minimized.

Copy link
Contributor Author

commented Dec 23, 2014

@martijnvg Pushed a new commit.

@martijnvg

This comment has been minimized.

Copy link
Member

commented Dec 23, 2014

LGTM!

@WearyMonkey

This comment has been minimized.

Copy link

commented Feb 9, 2015

I am experiencing these exceptions when performing aggregations with has_child filters. But in the same queries the doc_count of the has_child filter returns random values, usually +/- 10% of the correct amount.

Disabling the filter cache greatly reduces the randomness, but not entirely.

Can I check that the randomness is likely caused by this bug and will be fixed in 1.4.3? This is pretty nasty for us as customers lose a lot of trust in our product when they see numbers changing randomly, and we have no way of detecting errors.

Thanks!

@clintongormley clintongormley changed the title Parent/child: Fix concurrency issues of the _parent field data. Fix concurrency issues of the _parent field data. Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.