Use runtime java home for third party audit task #91412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We actually do indeed need to use the runtime Java for this task because depending on the target version, we may be loading classes for a later Java version. For example, if we use dependencies that are MR jars, then we in fact do load different classes depending on the runtime Java version. To test this properly then we need to use the target Java version to actually execute the task so it can both load the newer classes, and any classes from any newer APIs present in the later Java version.
mark-vieira
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
👍 |
breskeby
approved these changes
Nov 8, 2022
We're not configuring it twice, we simply on set it if runtime java is different than the compiler java. So otherwise it'll just use the default, which is the build java home. |
💚 Backport successful
|
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 8, 2022
We actually do indeed need to use the runtime Java for this task because depending on the target version, we may be loading classes for a later Java version. For example, if we use dependencies that are MR jars, then we in fact do load different classes depending on the runtime Java version. To test this properly then we need to use the target Java version to actually execute the task so it can both load the newer classes, and any classes from any newer APIs present in the later Java version.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2022
We actually do indeed need to use the runtime Java for this task because depending on the target version, we may be loading classes for a later Java version. For example, if we use dependencies that are MR jars, then we in fact do load different classes depending on the runtime Java version. To test this properly then we need to use the target Java version to actually execute the task so it can both load the newer classes, and any classes from any newer APIs present in the later Java version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually do indeed need to use the runtime Java for this task because depending on the target version, we may be loading classes for a later Java version. For example, if we use dependencies that are MR jars, then we in fact do load different classes depending on the runtime Java version. To test this properly then we need to use the target Java version to actually execute the task so it can both load the newer classes, and any classes from any newer APIs present in the later Java version.
Closes #91264