Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when using multi percolate api with routing #9161

Merged

Conversation

@martijnvg
Copy link
Member

commented Jan 6, 2015

Fixes a bug that was caused by specifying routing on a multi percolate request causing an ArrayIndexOutOfBoundsException.

The multi percolate shard responses are collected in an atomic array which uses the shard id is used as index, but the number of shards the multi percolate request was meant to go to was used as size of this array instead the total number of shards an index has and this caused the exception when routing was used.

PR for #6214

@rjernst

This comment has been minimized.

Copy link
Member

commented Jan 6, 2015

LGTM

Fixed a bug that was caused by specifying routing on a multi percolat…
…e request causing an ArrayIndexOutOfBoundsException.

The multi percolate shard responses are collected in an atomic array which uses the shard id is used as index, but the number of shards the multi percolate request was meant to go to was used as size of this array instead the total number of shards an index has. This caused the exception when routing was used.

Closes #6214

@martijnvg martijnvg force-pushed the martijnvg:bugs/multi_percolate_routing_bug branch to c94d056 Jan 7, 2015

@martijnvg martijnvg removed the review label Jan 7, 2015

@martijnvg martijnvg merged commit c94d056 into elastic:master Jan 7, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@clintongormley clintongormley changed the title Fixed bug when using multi percolate api with routing Percolator: Fixed bug when using multi percolate api with routing Feb 10, 2015

@martijnvg martijnvg deleted the martijnvg:bugs/multi_percolate_routing_bug branch May 18, 2015

@clintongormley clintongormley changed the title Percolator: Fixed bug when using multi percolate api with routing Fixed bug when using multi percolate api with routing Jun 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.