Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to make GET Index API consistent with docs #9178

Merged
merged 1 commit into from Jan 8, 2015

Conversation

@colings86
Copy link
Member

commented Jan 7, 2015

This fix ensures that calls to the GET alias/mappings/settings/warmers APIs return the aliases/mappings/settings/warmers object even if there is no content within them.. This make them consistent with the GET Index API docs and the breaking changes in 1.4 docs

Closes #9148

@colings86

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2015

@javanna would you mind reviewing this for me?

@javanna

This comment has been minimized.

Copy link
Member

commented Jan 7, 2015

hey @colings86 the change looks good to me, can we add some test for it though?

@colings86

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2015

@javanna Good point, I added rest tests to cover aliases, mappings, and warmers. The test isn't relevant for settings since an index can't have empty settings

@javanna

This comment has been minimized.

Copy link
Member

commented Jan 7, 2015

LGTM

@colings86 colings86 force-pushed the colings86:fix/9148 branch Jan 8, 2015

Indices API: Fix to make GET Index API consistent with docs
This fix ensures that calls to the GET alias/mappings/settings/warmers APIs return the aliases/mappings/settings/warmers object even if there is no content within them.. This make them consistent with the GET Index API docs and the breaking changes in 1.4 docs

Closes #9148

@colings86 colings86 force-pushed the colings86:fix/9148 branch to ecfe72e Jan 8, 2015

@colings86 colings86 removed the review label Jan 8, 2015

@colings86 colings86 assigned colings86 and unassigned javanna Jan 8, 2015

@colings86 colings86 merged commit ecfe72e into elastic:master Jan 8, 2015

1 check passed

CLA Commit author has signed the CLA
Details

@colings86 colings86 deleted the colings86:fix/9148 branch Jan 9, 2015

@grantr grantr referenced this pull request Jan 21, 2015

@clintongormley clintongormley changed the title Indices API: Fix to make GET Index API consistent with docs Fix to make GET Index API consistent with docs Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.