New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equality check of timevalue after serialization #9218

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mfelsche
Contributor

mfelsche commented Jan 9, 2015

TimeValue serialization changes timeUnit to NANOSECONDS and converts duration accordingly.
As .equals() and .hashCode() blindly compare those properties, equality is not conserved during serialization.

@rjernst

View changes

Show outdated Hide outdated src/main/java/org/elasticsearch/common/unit/TimeValue.java
@mfelsche

This comment has been minimized.

Show comment
Hide comment
@mfelsche

mfelsche Mar 6, 2015

Contributor

Sorry, i completely forgot about this PR.
Rebased on master.

Contributor

mfelsche commented Mar 6, 2015

Sorry, i completely forgot about this PR.
Rebased on master.

@rjernst

This comment has been minimized.

Show comment
Hide comment
@rjernst

rjernst Mar 6, 2015

Member

Thanks @mfelsche!

Member

rjernst commented Mar 6, 2015

Thanks @mfelsche!

@clintongormley clintongormley changed the title from fix equality check of timevalue after serialization to Fix equality check of timevalue after serialization Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment