Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In reverse nested aggregation, fix handling of the same child doc id being processed multiple times. #9345

Conversation

@martijnvg
Copy link
Member

commented Jan 19, 2015

PR for #9263

On the master, 1.x and 1.4 PR #9346 should be applied first.

@markharwood

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2015

Working through this and the one thing that looks like it would be beneficial for us and users, particularly given the complexity of these queries, is to have test examples that demonstrate a real use case rather than the very abstract foo/bar/baz examples.

@markharwood

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2015

Change to ReverseNestedAggregator looks good.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2015

LGTM

@martijnvg

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2015

@markharwood I'll update the test to use a more realistic example.

@martijnvg martijnvg force-pushed the martijnvg:bugs/reverse_nested_agg/same_childDoc_bucketOrd_combination_occur_multiple_times branch 2 times, most recently Jan 26, 2015

Aggs: fix handling of the same child doc id being processed multiple …
…times in the `reverse_nested` aggregation.

Closes #9263
Closes #9345

@martijnvg martijnvg force-pushed the martijnvg:bugs/reverse_nested_agg/same_childDoc_bucketOrd_combination_occur_multiple_times branch to 84d1f2e Jan 26, 2015

martijnvg added a commit that referenced this pull request Jan 26, 2015
Aggs: fix handling of the same child doc id being processed multiple …
…times in the `reverse_nested` aggregation.

Closes #9263
Closes #9345

@martijnvg martijnvg closed this in a645994 Jan 26, 2015

martijnvg added a commit that referenced this pull request Jan 26, 2015
Aggs: fix handling of the same child doc id being processed multiple …
…times in the `reverse_nested` aggregation.

Closes #9263
Closes #9345
martijnvg added a commit that referenced this pull request Jan 26, 2015
Aggs: fix handling of the same child doc id being processed multiple …
…times in the `reverse_nested` aggregation.

Closes #9263
Closes #9345

@clintongormley clintongormley changed the title Reverse nested aggregation: fix handling of the same child doc id being processed multiple times. Aggs: In reverse nested aggregation, fix handling of the same child doc id being processed multiple times. Feb 11, 2015

@martijnvg martijnvg deleted the martijnvg:bugs/reverse_nested_agg/same_childDoc_bucketOrd_combination_occur_multiple_times branch May 18, 2015

@clintongormley clintongormley changed the title Aggs: In reverse nested aggregation, fix handling of the same child doc id being processed multiple times. In reverse nested aggregation, fix handling of the same child doc id being processed multiple times. Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.