New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shard state tranport action names #9440

Closed
wants to merge 1 commit into
base: 1.x
from

Conversation

Projects
None yet
3 participants
@javanna
Member

javanna commented Jan 27, 2015

When we renamed all of the transport actions in #7105, shard started and failed were flipped around by mistake.
This didn't cause any actual problem as the change was made in a backwards compatible manner. That said the action names ended up being wrong (just a naming problem, meaning that started == failed and failed ==started) and we have to fix it, still maintaining backwards compatibility.

@jpountz

This comment has been minimized.

Contributor

jpountz commented Jan 27, 2015

@s1monw says: "Oh boy!" :)

@jpountz

This comment has been minimized.

Contributor

jpountz commented Jan 27, 2015

LGTM

On master, I think you would only have to fix the names?

@javanna

This comment has been minimized.

Member

javanna commented Jan 27, 2015

Yes in master it's easy, we don't care about bw compatibility aspects. The bw aspect in 1.x is tricky and not nice...but we have no other options than leave the wrong names around, which seems worse.

Internal: fix shard state tranport action names
When we renamed all of the transport actions in #7105, shard started and failed were flipped around by mistake.
This didn't cause any actual problem as the change was made in a backwards compatible manner. That said the action names ended up being wrong (just a naming problem, meaning that started == failed and failed ==started) and we have to fix it, still maintaining backwards compatibility.

@javanna javanna added >enhancement and removed >bug labels Jan 27, 2015

@jpountz

This comment has been minimized.

Contributor

jpountz commented Jan 27, 2015

Agreed

javanna added a commit that referenced this pull request Jan 27, 2015

Internal: fix shard state tranport action names
When we renamed all of the transport actions in #7105, shard started and failed were flipped around by mistake.
This didn't cause any actual problem as the change was made in a backwards compatible manner. That said the action names ended up being wrong (just a naming problem, meaning that started == failed and failed ==started) and we have to fix it, still maintaining backwards compatibility.

Closes #9440

@javanna javanna closed this in 93bf737 Jan 27, 2015

javanna added a commit that referenced this pull request Jan 28, 2015

[TEST] Fix ActionNamesTests post #9440
In #9440 we restored the proper transport action names for shard started and shard failed events. ActionNamesTests needs to be adjusted according to that change.

@clintongormley clintongormley added :Internal and removed review labels Mar 19, 2015

@clintongormley clintongormley changed the title from Internal: fix shard state tranport action names to Fix shard state tranport action names Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment