Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw StrictDynamicMappingException exception if `dynamic:strict` and undeclared field value is `null` #9445

Closed
wants to merge 2 commits into from

Conversation

@simaov
Copy link
Contributor

commented Jan 27, 2015

Throw StrictDynamicMappingException exception if dynamic is 'strict' and undeclared field value is NULL, test for this

Closes #9444

#9444 throw StrictDynamicMappingException exception if dynamic is 'st…
…rict' and undeclared field value is NULL, test for this
@@ -587,6 +587,10 @@ private void serializeNullValue(ParseContext context, String lastFieldName) thro
}
}
mapper.parse(context);
} else {
if (dynamic == Dynamic.STRICT) {

This comment has been minimized.

Copy link
@rjernst

rjernst Jan 27, 2015

Member

This can be joined together with the else into an else if.

@rjernst

This comment has been minimized.

Copy link
Member

commented Jan 27, 2015

@simaov Thanks for the fix! I had just one minor comment.

While you are making that change, could I please ask you to sign our CLA so we can merge this in?
http://www.elasticsearch.org/contributor-agreement/

@clintongormley

This comment has been minimized.

Copy link
Member

commented Jan 27, 2015

@rjernst CLA has been signed - could you merge?

@elasticsearch-bot

This comment has been minimized.

Copy link

commented Jan 27, 2015

Merged sucessfully into master 1.x 1.4 1.3!

jordansissel added a commit that referenced this pull request Jan 27, 2015
#9444 throw StrictDynamicMappingException exception if dynamic is 'st…
…rict' and undeclared field value is NULL, test for this

Fixes #9445
jordansissel added a commit that referenced this pull request Jan 27, 2015
jordansissel added a commit that referenced this pull request Jan 27, 2015
#9444 throw StrictDynamicMappingException exception if dynamic is 'st…
…rict' and undeclared field value is NULL, test for this

Fixes #9445
jordansissel added a commit that referenced this pull request Jan 27, 2015
#9444 join lines
Fixes #9445
jordansissel added a commit that referenced this pull request Jan 27, 2015
#9444 throw StrictDynamicMappingException exception if dynamic is 'st…
…rict' and undeclared field value is NULL, test for this

Fixes #9445
jordansissel added a commit that referenced this pull request Jan 27, 2015
jordansissel added a commit that referenced this pull request Jan 27, 2015

@rjernst rjernst removed the v1.3.9 label Jan 27, 2015

@rjernst

This comment has been minimized.

Copy link
Member

commented Jan 27, 2015

Thanks @simaov!

@spinscale spinscale changed the title Throw StrictDynamicMappingException exception Mapping: Throw StrictDynamicMappingException exception Jan 28, 2015

@clintongormley clintongormley changed the title Mapping: Throw StrictDynamicMappingException exception Throw StrictDynamicMappingException exception if `dynamic:strict` and undeclared field value is `null` Jun 7, 2015

mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
elastic#9444 throw StrictDynamicMappingException exception if dynamic…
… is 'strict' and undeclared field value is NULL, test for this

Fixes elastic#9445
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
elastic#9444 throw StrictDynamicMappingException exception if dynamic…
… is 'strict' and undeclared field value is NULL, test for this

Fixes elastic#9445
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.