Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type prefix support from field names in queries #9492

Closed
wants to merge 0 commits into from

Conversation

@rjernst
Copy link
Member

commented Jan 30, 2015

This is the first part of #8872.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2015

Looks great, I had not anticipated it would remove so much code.

How do you plan to proceed with updating the migration guide, do you plan to do it all in the end?

@rjernst rjernst force-pushed the rjernst:pr/8872-type-prefix-removal branch Feb 2, 2015
@rjernst

This comment has been minimized.

Copy link
Member Author

commented Feb 2, 2015

Thanks @jpountz. I've added a section to the migration guide as we discussed.

@rjernst rjernst closed this Feb 2, 2015
@rjernst rjernst force-pushed the rjernst:pr/8872-type-prefix-removal branch to 6079d88 Feb 2, 2015
@javanna

This comment has been minimized.

Copy link
Member

commented Feb 4, 2015

can you please label this @rjernst ?

@clintongormley

This comment has been minimized.

Copy link
Member

commented Feb 5, 2015

@rjernst could you add a link to the commit please?

If you had used closes #9492 in the commit message then it would have been added automatically

@rjernst

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2015

Commit is here: 6079d88

@rjernst rjernst deleted the rjernst:pr/8872-type-prefix-removal branch Mar 24, 2015
@clintongormley clintongormley changed the title Mappings: Remove type prefix support from field names in queries Remove type prefix support from field names in queries Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.