Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access modifiers to protected in Netty HTTP Transport #9724

Closed
wants to merge 1 commit into from

Conversation

@jaymode
Copy link
Member

commented Feb 17, 2015

Previously a few methods and many class members were package-private
or private and could not be referenced from overriding classes. This changes
the member variables and a few methods to have protected access, so they
can be referenced or overridden from a subclass.

Previously a few methods and many class members were package-private
or private and could not be referenced from overriding classes. This changes
the member variables and a few methods to have protected access, so they
can be referenced or overridden from a subclass.
@clintongormley

This comment has been minimized.

Copy link
Member

commented Feb 27, 2015

@javanna could you review please

@javanna

This comment has been minimized.

Copy link
Member

commented Feb 27, 2015

LGTM

@javanna javanna added >enhancement and removed review labels Feb 27, 2015
@jaymode

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2015

Committed in 4fbce94

@jaymode jaymode closed this Feb 27, 2015
@jaymode jaymode deleted the jaymode:http_transport branch Mar 16, 2015
@clintongormley clintongormley changed the title Netty HTTP Transport: Change access modifiers to protected Change access modifiers to protected in Netty HTTP Transport Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.