_cat/nodes: Thread null handling through stats and info #9938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was performing some testing the other day with various kinds of failure scenarios and still ran into
/_cat/nodes
giving me NPE (reminiscent of #6297). I was able to find at least three or four different objects that turned upnull
, includingJvmStats
. To play it safe I'd rather just catch nulls at as many points as we can (until we can useOptional
at least). The times when this happens are the most critical -- something is terribly wrong with the cluster -- and an erstwhile useful tool becomes useless.