Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add South Korea Munisipalities #74

Merged
merged 8 commits into from Jan 18, 2019
Merged

Add South Korea Munisipalities #74

merged 8 commits into from Jan 18, 2019

Conversation

@kimjmin
Copy link
Member

@kimjmin kimjmin commented Jan 16, 2019

This will add South Korean Munisipalities codes to Elastic Maps Service.

details at
sources/kr/README.md

kimjmin added 5 commits Jan 16, 2019
Update South Korea provinces
This will add South Korean Munisipalities codes to Elastic Maps Service.

details at
sources/kr/README.md
This will add South Korean Munisipalities codes to Elastic Maps Service.

details at
sources/kr/README.md

#2 : modified createAt / id
This will add South Korean Munisipalities codes to Elastic Maps Service.

details at
sources/kr/README.md

modified createAt / id
Missed quotation at createdAt field
@elasticmachine
Copy link
Collaborator

@elasticmachine elasticmachine commented Jan 16, 2019

@kimjmin
Copy link
Member Author

@kimjmin kimjmin commented Jan 16, 2019

@nickpeihl
Sorry for dirty #72 #73 issues.
Did several checks again but still failed.
Can you help me to figure out what is the problem?

Copy link
Contributor

@nickpeihl nickpeihl left a comment

Thank you so much for this! 🎉

The GeoJSON file is approximately 16MB which is quite large. As I understand it, the KOSTAT license allows us to remix the GeoJSON file as we need. So I propose that we simplify the geometry to make the file size smaller and faster to render.

The easiest way to simplify the data is to import the GeoJSON file into the Mapshaper.org webpage. Then use the Simplify tool and drag the slider to a reasonable level. I've found that 10% is often sufficient while keeping most of the boundary shape. Then use the Export feature on the webpage to export it to GeoJSON. Add rfc7946 to the "command line options" text box to reduce the file size even more. A file size less than 2MB is preferable.

Let me know if you have questions.

}
emsFormats: [{
type: geojson
file: south_korea_munisipalities_v1.geo.json

This comment has been minimized.

@nickpeihl

nickpeihl Jan 16, 2019
Contributor

This file name does not match the filename in the data directory.

This comment has been minimized.

@kimjmin

kimjmin Jan 17, 2019
Author Member

Thanks. fixed value and comit.

typo : change file name south_korea_municipalities_v1.geo.json
@elasticmachine
Copy link
Collaborator

@elasticmachine elasticmachine commented Jan 17, 2019

….org

Simplified south_korea_municipalities_v1.geo.json file with Mapshaper.org
@elasticmachine
Copy link
Collaborator

@elasticmachine elasticmachine commented Jan 17, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Collaborator

@elasticmachine elasticmachine commented Jan 17, 2019

@nickpeihl nickpeihl requested a review from thomasneirynck Jan 17, 2019
@nickpeihl
Copy link
Contributor

@nickpeihl nickpeihl commented Jan 17, 2019

LGTM!

I made a small change to your geojson file to reduce coordinate precision to 6 decimal places. I also prettified the geojson file which makes it easier to read in the repo. The geojson file will be automatically minified during deployment.

@thomasneirynck would you give this a review as well?

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

great to see this addition @kimjmin, thank you for effort to folding this into EMS!

@nickpeihl nickpeihl merged commit 2feec21 into elastic:master Jan 18, 2019
1 check passed
1 check passed
@elasticmachine
ems-ci Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants