Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiGlobalToastList render it into Left side props (currently it's default rightside) ? #3435

Closed
chetanmajithiya opened this issue May 7, 2020 · 4 comments · Fixed by #3600
Closed

EuiGlobalToastList render it into Left side props (currently it's default rightside) ? #3435

chetanmajithiya opened this issue May 7, 2020 · 4 comments · Fixed by #3600
Labels
feature request good first issue

Comments

@chetanmajithiya
Copy link

https://elastic.github.io/eui/#/display/toast
@chandlerprall
Copy link
Contributor

EuiGlobalToastList was designed to be on the right side of the screen to avoid obscuring the side nav bar. However, it makes sense to let this be configured by the application.

Will need a new prop, side, which defaults to right, along with an accompanying CSS class to change the element's fixed position.

@anishagg17
Copy link
Contributor

Working on this one

@shrey
Copy link
Contributor

shrey commented Jun 10, 2020

I'd like to work on this

@anishagg17
Copy link
Contributor

Go ahead @shrey

@shrey shrey mentioned this issue Jun 11, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added side property to 'EuiGlobalToastList' shrey/eui
4 participants
@chandlerprall @chetanmajithiya @anishagg17 @shrey