Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate EuiAccordion arrow on open #2507

Merged
merged 3 commits into from Nov 4, 2019

Conversation

@sqren
Copy link
Member

sqren commented Nov 1, 2019

Uses er 90 degree transition instead of fade-in.

@chandlerprall chandlerprall requested a review from cchaos Nov 1, 2019
@snide

This comment has been minimized.

Copy link
Contributor

snide commented Nov 1, 2019

Hey @sqren. The design here is fine. Do you mind if I commit directly and clean up the implementation? Specifically, this should use selectors rather than style attributes, and match against our animation timings.

@snide

This comment has been minimized.

Copy link
Contributor

snide commented Nov 1, 2019

PR4U against this branch #2509

If you can, try to create branches on your own fork.

@snide

This comment has been minimized.

Copy link
Contributor

snide commented Nov 1, 2019

I went ahead and merged it. It's the same end result, just a cleaner method. This is OK to review.

@snide snide changed the title [EuiAccordion] Use `arrowRight` transition Animate EuiAccordion arrow on open Nov 1, 2019
cl
@snide snide marked this pull request as ready for review Nov 1, 2019
@sqren

This comment has been minimized.

Copy link
Member Author

sqren commented Nov 3, 2019

@snide Thanks for fixing this up! LGTM 👍

@snide snide merged commit aaa1b5c into master Nov 4, 2019
2 checks passed
2 checks passed
CLA All commits in pull request signed
Details
eui-ci Build finished.
Details
@snide snide deleted the accordion-use-arrow-transition branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.