Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#2525 Make disabled button styles uniform #2534

Merged
merged 2 commits into from Nov 15, 2019

Conversation

@KarlaChen
Copy link
Contributor

KarlaChen commented Nov 15, 2019

Fixes #2525

I have add one line of code in scss, check and see is it what you want. If not, let me know, I can fix it.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Nov 15, 2019

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ryankeairns ryankeairns self-requested a review Nov 15, 2019
Copy link
Contributor

ryankeairns left a comment

Tried this out on several buttons throughout the Buttons page, in both light and dark mode. Works as expected, thanks @KarlaChen !

@ryankeairns ryankeairns self-requested a review Nov 15, 2019
Copy link
Contributor

ryankeairns left a comment

You will need to add an entry to the CHANGELOG though. Follow the pattern in the CHANGELOG.md to add a link to this PR with text that is past tense like "Fixed EuiButton disabled text color (link to PR)"

@cchaos

This comment has been minimized.

Copy link
Contributor

cchaos commented Nov 15, 2019

I also did a double-check, and can see that all the disabled states are consistent now. Thank you!

Some screenshots:

image
image
image

@KarlaChen

This comment has been minimized.

Copy link
Contributor Author

KarlaChen commented Nov 15, 2019

@ryankeairns I updated the CHANGELOG.md

@KarlaChen

This comment has been minimized.

Copy link
Contributor Author

KarlaChen commented Nov 15, 2019

@ryankeairns @cchaos You are welcome.

@ryankeairns ryankeairns self-requested a review Nov 15, 2019
Copy link
Contributor

ryankeairns left a comment

LGTM, thanks! Ready to merge.

@ryankeairns ryankeairns merged commit bbae157 into elastic:master Nov 15, 2019
1 check passed
1 check passed
CLA All commits in pull request signed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.