Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiTour] Convert to Emotion styling #6087

Merged
merged 21 commits into from
Aug 12, 2022
Merged

[EuiTour] Convert to Emotion styling #6087

merged 21 commits into from
Aug 12, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jul 28, 2022 •
edited
Loading

Summary

Like it says on the tin.

Also,

  • Adds a onPositionChange callback to EuiPopover for getting arrow placement
  • Fixes a proptype warning when using useEuiTour because it incorrectly expected onFinish to be part of each step config

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6087/

@thompsongl thompsongl mentioned this pull request Jul 28, 2022
Closed
49 tasks
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6087/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6087/

@thompsongl
Copy link
Contributor Author 

10:40:06   1) EuiDataGrid
10:40:06        focus management
10:40:06          cell keyboard interactions
10:40:06            cell expansion/interaction:
10:40:06 
10:40:06       Timed out retrying after 4000ms
10:40:06       + expected - actual
10:40:06 
10:40:06       -'dataGridRowCell'
10:40:06       +'focusOnMe'

jenkins test this

@thompsongl thompsongl marked this pull request as ready for review August 1, 2022 15:46
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6087/

@miukimiu miukimiu self-requested a review August 8, 2022 13:59
cee-chen
cee-chen reviewed Aug 8, 2022
View reviewed changes
src/components/tour/tour.styles.ts
Comment on lines +34 to +41
[data-popover-arrow='top'] {
&:before {
${logicalCSS(
'border-top-color',
backgroundColor(euiTheme.colors.lightestShade, colorMode)
)};
}
}
Copy link
Member

@cee-chen cee-chen Aug 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[not a blocking comment, just noting something] I know this is just a translation from Sass so this is already happening in prod, but it looks like left/right arrows that are close to the colored footer also have incorrect arrow colors:

tbh not a huge deal and i'm not sure if there's a way of programmatically detecting this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember not being able to account for this when writing the Sass styles originally, but maybe we can do some calculations now? I'll look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to timebox / no worries if it's too much of a hassle, we can punt!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember not being able to account for this when writing the Sass styles originally, but maybe we can do some calculations now? I'll look.

It would be great to support this. 👍🏽

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't quite got this yet but don't want to hold up this PR any longer. I'll do a follow-up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries at all!

cee-chen
cee-chen reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great to me, I have a few nits and questions, but otherwise QA looks great, logical properties all look good, and I'm really digging how the Emotion styles were organized!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6087/

miukimiu
miukimiu approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thompsongl!

Tested in Chrome, Safari, Edge, and Firefox. LGTM! 🎉

src/components/tour/tour.styles.ts
Comment on lines +34 to +41
[data-popover-arrow='top'] {
&:before {
${logicalCSS(
'border-top-color',
backgroundColor(euiTheme.colors.lightestShade, colorMode)
)};
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember not being able to account for this when writing the Sass styles originally, but maybe we can do some calculations now? I'll look.

It would be great to support this. 👍🏽

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6087/

cee-chen
cee-chen approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@cee-chen cee-chen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor comment left - since it's small, I'll go ahead and approve. Other changes look great, thanks!

thompsongl and others added 2 commits August 12, 2022 11:23
@thompsongl
Update src/components/tour/tour_step_indicator.tsx
abfad7c 
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
@thompsongl
snapshots
34259bc
@thompsongl thompsongl enabled auto-merge (squash) August 12, 2022 17:55
@thompsongl
Copy link
Contributor Author

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6087/

@thompsongl thompsongl merged commit d2ea7d4 into elastic:main Aug 12, 2022
@1Copenut 1Copenut mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

@miukimiu miukimiu miukimiu approved these changes

Assignees
No one assigned
Labels
emotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thompsongl @kibanamachine @cee-chen @miukimiu