From e44a951d345e2fbeda3101364a613be780f2bd8e Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 13 Sep 2023 12:46:55 -0700 Subject: [PATCH 1/4] [EuiDescriptionListTitle] Fix missed override Sass --- .../description_list/description_list_title.styles.ts | 3 ++- src/themes/amsterdam/overrides/_description_list.scss | 7 ------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/components/description_list/description_list_title.styles.ts b/src/components/description_list/description_list_title.styles.ts index 7f6647c1ec7..ed600631f2c 100644 --- a/src/components/description_list/description_list_title.styles.ts +++ b/src/components/description_list/description_list_title.styles.ts @@ -66,7 +66,8 @@ export const euiDescriptionListTitleStyles = (euiThemeContext: UseEuiTheme) => { ${logicalCSS('padding-horizontal', euiTheme.size.xs)} `, compressed: css` - ${euiFontSize(euiThemeContext, 'xs')} + font-size: ${euiFontSize(euiThemeContext, 'xs').fontSize}; + line-height: ${euiTheme.font.lineHeightMultiplier}; ${logicalCSS('padding-vertical', '0')} ${logicalCSS('padding-horizontal', euiTheme.size.xs)} `, diff --git a/src/themes/amsterdam/overrides/_description_list.scss b/src/themes/amsterdam/overrides/_description_list.scss index 9cd4ca8370a..e69de29bb2d 100644 --- a/src/themes/amsterdam/overrides/_description_list.scss +++ b/src/themes/amsterdam/overrides/_description_list.scss @@ -1,7 +0,0 @@ -.euiDescriptionList { - &.euiDescriptionList--inline.euiDescriptionList--compressed { - .euiDescriptionList__title { - line-height: $euiLineHeight; - } - } -} From feeadd37ef0c0a11465242dd810b78a94f78b948 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 13 Sep 2023 12:47:17 -0700 Subject: [PATCH 2/4] Delete Sass files --- src/themes/amsterdam/overrides/_description_list.scss | 0 src/themes/amsterdam/overrides/_index.scss | 1 - 2 files changed, 1 deletion(-) delete mode 100644 src/themes/amsterdam/overrides/_description_list.scss diff --git a/src/themes/amsterdam/overrides/_description_list.scss b/src/themes/amsterdam/overrides/_description_list.scss deleted file mode 100644 index e69de29bb2d..00000000000 diff --git a/src/themes/amsterdam/overrides/_index.scss b/src/themes/amsterdam/overrides/_index.scss index e9af2a3f536..9e837c1b800 100644 --- a/src/themes/amsterdam/overrides/_index.scss +++ b/src/themes/amsterdam/overrides/_index.scss @@ -1,6 +1,5 @@ @import 'combo_box'; @import 'data_grid'; -@import 'description_list'; @import 'form_control_layout'; @import 'form_control_layout_delimited'; @import 'form_controls'; From b1b7a098a71b6b176ae3264790040894b803c299 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 13 Sep 2023 12:48:38 -0700 Subject: [PATCH 3/4] Fix inline titles being passed a margin-top that does nothing --- .../__snapshots__/description_list_title.test.tsx.snap | 2 +- src/components/description_list/description_list_title.tsx | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/description_list/__snapshots__/description_list_title.test.tsx.snap b/src/components/description_list/__snapshots__/description_list_title.test.tsx.snap index e3e28fa0c85..a7516812fe2 100644 --- a/src/components/description_list/__snapshots__/description_list_title.test.tsx.snap +++ b/src/components/description_list/__snapshots__/description_list_title.test.tsx.snap @@ -26,7 +26,7 @@ exports[`EuiDescriptionListTitle EuiDescriptionListTitle prop variations type co exports[`EuiDescriptionListTitle EuiDescriptionListTitle prop variations type inline is rendered 1`] = `
`; diff --git a/src/components/description_list/description_list_title.tsx b/src/components/description_list/description_list_title.tsx index 877bdab3b03..7f5167693c9 100644 --- a/src/components/description_list/description_list_title.tsx +++ b/src/components/description_list/description_list_title.tsx @@ -40,7 +40,6 @@ export const EuiDescriptionListTitle: FunctionComponent< conditionalStyles = compressed ? [styles.inlineStyles.compressed] : [styles.inlineStyles.normal]; - conditionalStyles.push(styles[rowGutterSize]); break; case 'row': conditionalStyles.push(styles[rowGutterSize]); From d97e55f3239fe98115d45b61746591f29880bd0b Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 13 Sep 2023 12:58:30 -0700 Subject: [PATCH 4/4] changelog --- upcoming_changelogs/7185.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 upcoming_changelogs/7185.md diff --git a/upcoming_changelogs/7185.md b/upcoming_changelogs/7185.md new file mode 100644 index 00000000000..8483bf27e35 --- /dev/null +++ b/upcoming_changelogs/7185.md @@ -0,0 +1,4 @@ +**Bug fixes** + +- Fixed the inline compressed styles of `EuiDescriptionListTitle` to use a taller line-height for readability +