-
Notifications
You must be signed in to change notification settings - Fork 635
test: check errors in test suite #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Hi. I'm sorry but I am not a maintainer here. |
|
Ping @Anaethelion |
|
Hi @HaraldNordgren , thank you for this contribution! I will review this and get back to you ASAP |
52621ab to
e5d381d
Compare
|
@MattDevy Ping |
MattDevy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaraldNordgren apologies for the delay on this.
LGTM! Thank you for this contribution, I will follow up with a PR to tweak the linting rules for error checking in tests
|
Thanks! @MattDevy Is there a linter running? I couldn't find one. |
It's bad to skip error checking.
Would also be good to have a linter for this.