Skip to content

Conversation

@HaraldNordgren
Copy link
Contributor

@HaraldNordgren HaraldNordgren commented Oct 24, 2025

It's bad to skip error checking.

Would also be good to have a linter for this.

@prodsecmachine
Copy link

prodsecmachine commented Oct 24, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@HaraldNordgren HaraldNordgren marked this pull request as ready for review October 25, 2025 11:04
@Jakub-Kapusta
Copy link

Ping @Anaethelion @Jakub-Kapusta

Hi. I'm sorry but I am not a maintainer here.
Not much I can do.
I however agree that it is always better to check the errors.

@HaraldNordgren
Copy link
Contributor Author

Ping @Anaethelion

@MattDevy
Copy link
Contributor

Hi @HaraldNordgren , thank you for this contribution! I will review this and get back to you ASAP

@MattDevy MattDevy self-requested a review November 21, 2025 13:43
@MattDevy MattDevy changed the title check errors in test suite test: check errors in test suite Nov 21, 2025
@MattDevy MattDevy self-assigned this Nov 21, 2025
@HaraldNordgren
Copy link
Contributor Author

@MattDevy Ping

Copy link
Contributor

@MattDevy MattDevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaraldNordgren apologies for the delay on this.

LGTM! Thank you for this contribution, I will follow up with a PR to tweak the linting rules for error checking in tests

@MattDevy MattDevy merged commit a440b0c into elastic:main Dec 2, 2025
16 checks passed
@HaraldNordgren
Copy link
Contributor Author

Thanks!

@MattDevy Is there a linter running? I couldn't find one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants