Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FreeBSD. #33

Merged
merged 1 commit into from Jun 29, 2016
Merged

Add support for FreeBSD. #33

merged 1 commit into from Jun 29, 2016

Conversation

knz
Copy link

@knz knz commented Jun 22, 2016

This implementation requires to mount the Linux compatibility /proc
filesystem in /compat/linux/proc. Check the FreeBSD handbook for
details.

@ruflin
Copy link
Member

ruflin commented Jun 22, 2016

@knz Thanks for the contribution. Could you use gofmt -w ... to make sure your code adheres to the golang standard? Currently travis complains.

@knz knz force-pushed the master branch 3 times, most recently from a0aeb4d to 5c0965d Compare June 22, 2016 08:15
@knz
Copy link
Author

knz commented Jun 22, 2016

@ruflin thanks for the hint. Also now there is significant shared/redundant code between sigar_linux.go and sigar_freebsd.go. Do you see a way to reduce this redundancy?

@codecov-io
Copy link

codecov-io commented Jun 22, 2016

Current coverage is 73.06%

Merging #33 into master will increase coverage by 1.47%

@@             master        #33   diff @@
==========================================
  Files             9         10     +1   
  Lines          1063        787   -276   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            761        575   -186   
+ Misses          246        172    -74   
+ Partials         56         40    -16   

Powered by Codecov. Last updated by f42b670...a250079

@tamird
Copy link

tamird commented Jun 22, 2016

@knz you might be able to move some things into gosigar_unix, or else create a new file that doesn't end in _GOOS and use build tags to control when it is built.

@knz
Copy link
Author

knz commented Jun 22, 2016

@tamird good idea! I just did this and it works well. Thanks!

@tamird
Copy link

tamird commented Jun 22, 2016

looks like there's some new interaction with darwin that is failing in travis.

This implementation requires to mount the Linux compatibility /proc
filesystem in /compat/linux/proc. Check the FreeBSD handbook for
details.
@knz
Copy link
Author

knz commented Jun 28, 2016

Ping, any news on this one?

@monicasarbu
Copy link

@knz thank you for your contribution. I am merging your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants