New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for FreeBSD. #33
Conversation
@knz Thanks for the contribution. Could you use |
a0aeb4d
to
5c0965d
Compare
@ruflin thanks for the hint. Also now there is significant shared/redundant code between sigar_linux.go and sigar_freebsd.go. Do you see a way to reduce this redundancy? |
Current coverage is 73.06%@@ master #33 diff @@
==========================================
Files 9 10 +1
Lines 1063 787 -276
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 761 575 -186
+ Misses 246 172 -74
+ Partials 56 40 -16
|
@knz you might be able to move some things into gosigar_unix, or else create a new file that doesn't end in |
@tamird good idea! I just did this and it works well. Thanks! |
looks like there's some new interaction with darwin that is failing in travis. |
This implementation requires to mount the Linux compatibility /proc filesystem in /compat/linux/proc. Check the FreeBSD handbook for details.
Ping, any news on this one? |
@knz thank you for your contribution. I am merging your PR. |
This implementation requires to mount the Linux compatibility /proc
filesystem in /compat/linux/proc. Check the FreeBSD handbook for
details.