Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[meta] Helm 3 #516

Merged
merged 39 commits into from Nov 17, 2020
Merged

[meta] Helm 3 #516

merged 39 commits into from Nov 17, 2020

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Mar 13, 2020

This is a draft PR to run all CI tests with Helm 3

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Related to #401
Fix #492

@jmlrt
Copy link
Member Author

jmlrt commented Mar 19, 2020

jenkins test this please

2 similar comments
@jmlrt
Copy link
Member Author

jmlrt commented Mar 19, 2020

jenkins test this please

@jmlrt
Copy link
Member Author

jmlrt commented Mar 20, 2020

jenkins test this please

@pgold30
Copy link

pgold30 commented Apr 1, 2020

Hi there , i was able to install elastic , kbana and metricbeat using helm 3 on eks 1.15 , is there work ongoing here related to logstash or i could use this branch and deploy logstash too ? Thanks!

@jmlrt
Copy link
Member Author

jmlrt commented Apr 2, 2020

Hi there , i was able to install elastic , kbana and metricbeat using helm 3 on eks 1.15 , is there work ongoing here related to logstash or i could use this branch and deploy logstash too ? Thanks!

Hi @pgold30

We still have a strange issue with Logstash where 7.x versions seem working fine but 6.x tests are failing.

For the other charts we didn't have to update templates to make them compatible with Helm 3 and our last issues and remaining work are mostly related to our own testing environment.

In conclusion if you want to use Logstash 7.x with Helm 3, you should be able to use this branch.

Please note that while we haven't finished our test and the master branch doesn't specify that Helm 3 is supported in https://github.com/elastic/helm-charts/blob/master/README.md#helm-versions, we still don't recommand using Helm 3.

@joscha-alisch
Copy link

Hi @jmlrt, any news on this?
This is the only chart that we use that doesn't work with helm 3 and prevents us from completely updating.

Very happy to contribute, if there is anything I can do to help!

@jmlrt
Copy link
Member Author

jmlrt commented Apr 15, 2020

Hi @joscha-alisch,
We had to pause this PR for now because setting the full CI environment to test and support both Helm 2 and Helm 3 is more work than expected and we have other priorities. We hope being able to restart work on it in 2-3 weeks.

Meanwhile, if you want to use Helm 3, you should be able to deploy every charts but Logstash using master branch or 7.6.2. While not supported and not fully tested until we have our CI environment updated, they are known to work with Helm 3.

If you need to run Logstash chart with Helm 3 AND you are using Logstash 7.x version, you can use the chart from this branch, it seems working well. Don't hesitate to give us feedback about it.

If you need to run Logstash chart with Helm 3 AND you are using Logstash 6.x version, this chart is not working yet due to some strange behavior in our tests. I would advise you to wait that we fix it.

jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 17, 2020
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to elastic#127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
This was referenced Nov 17, 2020
jmlrt added a commit that referenced this pull request Nov 18, 2020
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to #127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
jmlrt added a commit that referenced this pull request Nov 18, 2020
* bump helm version to helm 3.4.1
* update doc to make helm 3 the recommended version
* update helm commands arguments for helm 3
* remove helm init and tiller install commands
* add stable repo for metricbeat dependencies
* remove the charts dance in helmignore (related to #127)
* optimize docker images
* replace deprecated gitversion capability (related to helm/helm#5601)
* remove some heritage labels in immutable fields
@jmlrt jmlrt mentioned this pull request Nov 19, 2020
jmlrt added a commit that referenced this pull request Nov 20, 2020
This PR is adding a new upgrade test for every chart.

This test is deploying the oldest **release** version of charts which can be upgraded to latest version, then upgrading using unreleased charts in the repo.

The goal is to detect when some PR is introducing a breaking change.

- Note 1: An upgrade test is already existing for Elasticsearch but had been removed from master branch because upgrade from 7.x to Elasticsearch 8.0.0-SNAPSHOT used by master branch isn't working. The new test allows overriding the Docker image version used during upgrade so we can still test upgrade on master but use the latest 7.x Docker image instead of 8.0.0-SNAPSHOT.

* Note 2:  Metricbeat chart introduced a breaking change in #516 and can be upgraded from any previous version currently, so Metricbeat test is commented and should be uncommented after 7.10.0 release so we can check if new PR are introducing new breaking changes.

* Note 3: Currently charts upgrade are only tested with default values and so cover a small part of charts codebase, we should update it to test optional resources (ie: enable service or ingress, ...).

Fix #396
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 20, 2020
This PR is adding a new upgrade test for every chart.

This test is deploying the oldest **release** version of charts which can be upgraded to latest version, then upgrading using unreleased charts in the repo.

The goal is to detect when some PR is introducing a breaking change.

- Note 1: An upgrade test is already existing for Elasticsearch but had been removed from master branch because upgrade from 7.x to Elasticsearch 8.0.0-SNAPSHOT used by master branch isn't working. The new test allows overriding the Docker image version used during upgrade so we can still test upgrade on master but use the latest 7.x Docker image instead of 8.0.0-SNAPSHOT.

* Note 2:  Metricbeat chart introduced a breaking change in elastic#516 and can be upgraded from any previous version currently, so Metricbeat test is commented and should be uncommented after 7.10.0 release so we can check if new PR are introducing new breaking changes.

* Note 3: Currently charts upgrade are only tested with default values and so cover a small part of charts codebase, we should update it to test optional resources (ie: enable service or ingress, ...).

Fix elastic#396
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 20, 2020
This PR is adding a new upgrade test for every chart.

This test is deploying the oldest **release** version of charts which can be upgraded to latest version, then upgrading using unreleased charts in the repo.

The goal is to detect when some PR is introducing a breaking change.

- Note 1: An upgrade test is already existing for Elasticsearch but had been removed from master branch because upgrade from 7.x to Elasticsearch 8.0.0-SNAPSHOT used by master branch isn't working. The new test allows overriding the Docker image version used during upgrade so we can still test upgrade on master but use the latest 7.x Docker image instead of 8.0.0-SNAPSHOT.

* Note 2:  Metricbeat chart introduced a breaking change in elastic#516 and can be upgraded from any previous version currently, so Metricbeat test is commented and should be uncommented after 7.10.0 release so we can check if new PR are introducing new breaking changes.

* Note 3: Currently charts upgrade are only tested with default values and so cover a small part of charts codebase, we should update it to test optional resources (ie: enable service or ingress, ...).

Fix elastic#396
jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Nov 20, 2020
This PR is adding a new upgrade test for every chart.

This test is deploying the oldest **release** version of charts which can be upgraded to latest version, then upgrading using unreleased charts in the repo.

The goal is to detect when some PR is introducing a breaking change.

- Note 1: An upgrade test is already existing for Elasticsearch but had been removed from master branch because upgrade from 7.x to Elasticsearch 8.0.0-SNAPSHOT used by master branch isn't working. The new test allows overriding the Docker image version used during upgrade so we can still test upgrade on master but use the latest 7.x Docker image instead of 8.0.0-SNAPSHOT.

* Note 2:  Metricbeat chart introduced a breaking change in elastic#516 and can be upgraded from any previous version currently, so Metricbeat test is commented and should be uncommented after 7.10.0 release so we can check if new PR are introducing new breaking changes.

* Note 3: Currently charts upgrade are only tested with default values and so cover a small part of charts codebase, we should update it to test optional resources (ie: enable service or ingress, ...).

Fix elastic#396
@jmlrt jmlrt deleted the helm-3 branch November 20, 2020 12:17
@jmlrt jmlrt mentioned this pull request Nov 23, 2020
@jmlrt jmlrt changed the title Helm 3 [meta] Helm 3 Nov 23, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm upgrade fails due to 'cannot patch "elasticsearch-master" with kind StatefulSet'
4 participants